Closed (fixed)
Project:
Feeds
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Dec 2014 at 11:36 UTC
Updated:
20 Aug 2015 at 03:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
megachrizComment #2
megachrizSounds like it's easy to solve. Tagging as a novice issue.
Comment #3
megachrizComment #4
pravin ajaaz commentedPatch adds Quotes for target column name that contains comma.
Comment #5
pravin ajaaz commentedComment #6
megachrizWhen I have a mapping source called "eats, shoots, and leaves" (manually entered on the mapping form) I still see the following when I go to /import/%importer_id:
I think the change need to be made in /plugins/FeedsCSVParser.inc.
Comment #7
pravin ajaaz commentedSorry I miss understood the OP. Thanks for guiding me.
Comment #8
pravin ajaaz commentedComment #9
megachrizTested and works okay. Tiny coding standard issues, though:
https://www.drupal.org/coding-standards#naming
https://www.drupal.org/coding-standards#functcall
Otherwise good.
Comment #10
pravin ajaaz commented@MegaChriz: Thanks for the review. I made the recommended changes
Comment #11
megachrizGood. I see no more issues with this patch. RTBC.
Comment #12
twistor commentedThis should check for $this->config['delimiter'];, rather than hard code the delimiter.
Comment #13
pravin ajaaz commentedI think I am not hard coding delimiter here. Just adding quotes to the column names which are comma separated.
Comment #14
megachriz@twistor I thought at first too that something with the delimiter needed to be done, but that isn't the case. It is only the text in the UI that tells which columns should be used in the CSV and the UI text always separates the column names with comma's, regardless of the delimiter. This issue is about fixing the UI text in case comma's are used in column names.

See also the attached image:
Back to RTBC.
Comment #16
twistor commentedWorks for me, thanks!
There's still going to be some oddness, if the column contains a quote character, but that should be rare.