When trying to click 'override' on a node with no content type mapping defined, 'override' does not work.

CommentFileSizeAuthor
#4 557504-4_override_unexpected_behaviour.patch2.49 KBalex_b
#1 557504-1_override_unexpected_behaviour.patch2.45 KBaron novak

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Needs review
StatusFileSize
new 557504-1_override_unexpected_behaviour.patch2.45 KB

There is also another problem: you have per-node mapping, you start deleting the entries and when it becomes empty, it suddenly becomes per-content-type.
Both of these issues are fixed in the patch. Conflicts with #557500: Resolve naming conflict "override per content type setting" and "override default". Tests are 100%

Also, with this patch, finally there is only one ctools_export_load_object() call in the whole .module file. This is the icing on the cake :)

alex_b’s picture

alex_b commented

Should we commit #557500: Resolve naming conflict "override per content type setting" and "override default" first and then mature this patch?

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented

#2: mature this patch? This patch is fine, as i told, it conflicts w/ that patch, but it's only because of naming changes. Of course, it needs to be rerolled after #557500: Resolve naming conflict "override per content type setting" and "override default" is in.

alex_b’s picture

alex_b commented
StatusFileSize
new 557504-4_override_unexpected_behaviour.patch2.49 KB

Updated after #557500: Resolve naming conflict "override per content type setting" and "override default" landed.

'per_node_placeholder' - shouldn't we introduce a general empty flag? E. g. 'NOMAPPING'?