Mapping feed language to feed items

Based on what information would you set the language?

I've created a patch for the 6.x-1.2 version of feedapi_inherit.module that implements this feature:

Functionality:
When enabled in the feeds settings the language of the feed_node will get passed onto all feed_items

Disclaimer: This is my first patch submission so please let me know if I screwed up anything. It seems to be working just fine on my site, I hope it will work for others.

Cheers!

Paul K

hi SqyD,

Great work, gonna test it. I am reworking your patch for feedapi 5 and looked closely at it.

Should

$inherit_og = $feed_node->feed->settings['processors']['feedapi_inherit']['inherit_language'];

not be

$inherit_language = $feed_node->feed->settings['processors']['feedapi_inherit']['inherit_language'];

Maybe this is also your problem, Designer?

In addition to my previous comment

if ($inherit_language && module_exists('translation')) {

should be

if ($inherit_translation && module_exists('translation')) {

The attached file should work for feedapi & drupal5.

Backup the old modules/feedapi/feedapi_inherit/feedapi_inherit.module file and overwrite with this one.

Attached is an updated patch for feedapi & drupal 6. Not tested, but should work.

Hey buzink,

Thanks for the review and the fixes. I will test them over the weekend.
[Update]: I tested both 5.x and 6.x versions and all seems to work perfectly now, Thanx!

Sorry for the mess all. I haven't been looking at the test site I was using this module in for some time and noticed it didn't work anymore for me too. I think I messed up uploading the submitted version and got bitten by some caching problem since the checks and prefs (that included the errors you found) I added later then the actual logic that was still creating language enabled nodes...

I patched the current release today with the patch buzzink posted before and everything is still working smooth. I recommend merging this into the next release.

I think this functionality is great, it would greatly enhance those aggregating multilingual feeds.

I installed the latest version of the module and I did not find this functionality. Is there a plan to include it in an upcoming release?

This is RTBC from my point of view. Let's remove the stray empty line when committing.

Thank you for the work!