Undefined index

hi!
i'm experiencing the same problem. did you find any solution?

I think this is known, but in the end it does work, correct? Is the error message the only issue?

subscribing

#2 No, in the end, it does not work.

Here is a patch which fixes the issues.

Wow the patch in #5 seems to fix a lot more than just the 'undefined index' error.

Patch in #5 needs work:

• Reuse fe_block_settings_features_revert() and fe_block_boxes_features_revert() instead of duplicating code.
• It is not clear to me why this code is used instead of drupal_write_record(), it seems to do the exact same thing?
  

  +        $fields = $block;
  +        if (isset($fields['machine_name'])) {
  +          unset($fields['machine_name']);
  +        }
  +        db_merge('block')
  +          ->key(array('module' => $block['module'], 'delta' => $block['delta'], 'theme' => $custom_theme))
  +          ->fields($fields)
  +          ->execute();
  

Here's the fix I used in my sandbox to get rid of the notice:

diff --git a/fe_block.module b/fe_block.module
index d62baa5..9c3b1c1 100644
--- a/fe_block.module
+++ b/fe_block.module
@@ -201,6 +201,9 @@ function fe_block_settings_features_revert($module_name = NULL) {
   global $custom_theme, $theme_key;
   $component = 'fe_block_settings';
   $defaults = features_get_default($component, $module_name);
+  if (empty($defaults)) {
+    return;
+  }
 
   // Provide backwards compatibility with the old export format that only
   // supported theme specific settings.

Refs:

• Sandbox
• commit a18f648

I split up Guillaume's patch into the 3 different problems it actually addresses and committed them to my sandbox:

• Issue #1225524 by guillaumev: Clear the bid cache when reverting block settings.
• Issue #1225524 by guillaumev: Clear the block cache after reverting block settings or block boxes.
• Issue #1758646 by guillaumev, pfrenssen: Fixed enabling feature does not create exported block.

I'm working in this sandbox because I urgently need to get some features and bugfixes in Features Extra before a deadline later this week. I lack the time to reroll all patches properly to the current 7.x-1.x.

I hope that this sandbox can be merged in with the main project after approval by the maintainers.

This has been committed. Thanks!

• Issue #1225524 by guillaumev: Clear the block cache after reverting block settings or block boxes.
• Issue #1225524 by guillaumev: Clear the bid cache when reverting block settings.
• Issue #1225524 by pfrenssen: Fix notice when trying to revert a block.