Enable testing in all branches for PHP 8.0.

Comments

Liam Morland created an issue. See original summary.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Needs review

Thx for the suggestion. I've added a couple of tests. Please review when you get a chance and confirm if that's sufficient.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

I didn't add a test for 7.x-2.x because I don't maintain that branch.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 8.x-4.x-dev » 7.x-2.x-dev
Status: Needs review » Active

Thanks. Looks good for Drupal 8. Still needed for 7.x-2.x.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Testing Features 7.x-2.x in PHP 8.0 causes a test failure in image.module. I have posted a core fix in #3208079: Trying to access array offset on value of type bool in image.module.

poker10’s picture

poker10 commented

I think this can be closed, as the PHP 8+ testing is already enabled and it is green: https://www.drupal.org/node/401392/qa