Problem/Motivation

To aid with settings provided by modules - https://www.drupal.org/docs/8/modules/features/settings-provided-by-othe...

There's a use case for excluding certain active configuration properties from being exported (or showing up as overrides in the diff).

An API hook has been added to allow custom modules to manipulate the override configurations.

Proposed resolution

Add module API alter hook allowing developers to manipulate the configuration object.

User interface changes

N/A

API changes

New hook_features_storage_alter hook.

CommentFileSizeAuthor
#8 3136133-alter-storage-config-before-diffing-8.diff4.03 KBcodebymikey
#2 3136133-alter-storage-config-before-diffing-2.patch4.79 KBcodebymikey

Issue fork features-3136133

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

codebymikey commented
Status: Active » Needs review
StatusFileSize
new 3136133-alter-storage-config-before-diffing-2.patch4.79 KB
codebymikey’s picture

codebymikey commented
Title: Provide API hook for alter the config data » Provide API hook for altering the config data before diff-ing
nedjo’s picture

nedjo
he/him/his
Primary language English
commented

@codebymikey, Is this needed as well as #3136087: Provide PRE- event hooks for import, revert and delete commands, or can we close this issue?

codebymikey’s picture

codebymikey commented

@nedjo, they're both needed.

This behaviour is specific to the diff (before config_update is called for reverts/imports) to determine whether a config shows up as changed or not, whereas #3136087: Provide PRE- event hooks for import, revert and delete commands is for the actual behaviour during revert/import.

Ideally they'd be implemented as a single hook/event, but since the behaviour is currently implemented in different modules, I think it's better for the hooks to be separate and the developer would integrate them as needed.

codebymikey’s picture

codebymikey commented
Version: 8.x-4.x-dev » 5.0.x-dev

Switching to target the 5.0.x branch

codebymikey opened merge request !26

codebymikey’s picture

codebymikey commented
StatusFileSize
new 3136133-alter-storage-config-before-diffing-8.diff4.03 KB

Apply a patch targetting 5.0.x.

Status: Needs review » Needs work

The last submitted patch, 8: 3136133-alter-storage-config-before-diffing-8.diff, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

codebymikey’s picture

codebymikey commented
Version: 5.0.x-dev » 8.x-3.x-dev

Still need to update unit tests, but switching MR to target 8.x-3.x-dev instead