Reverting features can trigger multiple menu rebuilds, which can be very very slow.

One way to work around this problem would be to call menu_rebuild() just once at the end.

This requires a patch to both features module and ctools module: #2989620: Performance enhancement: Allow menu_rebuild() to be skipped.

There are other possibilities that I didn't explore, such as registering a shutdown function.

CommentFileSizeAuthor
features-skip-menu-rebuild.patch625 bytesmfb

Comments

mfb created an issue. See original summary.

joseph.olstad’s picture

triggered another test.

joseph.olstad’s picture

Status: Needs review » Reviewed & tested by the community

looks great thanks

joseph.olstad’s picture

Status: Reviewed & tested by the community » Postponed

this looks great, curiously it actually passes testing despite ctools not having this, I supposed the extra param is ignored.
Probably wouldn't hurt to push this in now, but we should probably wait for ctools to push this up as it won't actually do anything until ctools puts it in.

mfb’s picture

Thanks for the review :) Without the other patch applied it's just adding an extra menu rebuild, i.e. a small performance degradation.

joelpittet’s picture

Status: Postponed » Needs review

Committed upstream patch

joseph.olstad’s picture

Thanks Joel! I'll try to get this in soon.

joseph.olstad’s picture

Status: Needs review » Reviewed & tested by the community

  • joseph.olstad committed 524b370 on 7.x-2.x authored by mfb
    Issue #2989623 by mfb, joseph.olstad, joelpittet: Performance...
joseph.olstad’s picture

Status: Reviewed & tested by the community » Fixed

Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.