Reverting features can trigger multiple menu rebuilds, which can be very very slow.
One way to work around this problem would be to call menu_rebuild() just once at the end.
This requires a patch to both features module and ctools module: #2989620: Performance enhancement: Allow menu_rebuild() to be skipped.
There are other possibilities that I didn't explore, such as registering a shutdown function.
| Comment | File | Size | Author |
|---|---|---|---|
| features-skip-menu-rebuild.patch | 625 bytes | mfb |
Comments
Comment #2
joseph.olstadtriggered another test.
Comment #3
joseph.olstadlooks great thanks
Comment #4
joseph.olstadthis looks great, curiously it actually passes testing despite ctools not having this, I supposed the extra param is ignored.
Probably wouldn't hurt to push this in now, but we should probably wait for ctools to push this up as it won't actually do anything until ctools puts it in.
Comment #5
mfbThanks for the review :) Without the other patch applied it's just adding an extra menu rebuild, i.e. a small performance degradation.
Comment #6
joelpittetCommitted upstream patch
Comment #7
joseph.olstadThanks Joel! I'll try to get this in soon.
Comment #8
joseph.olstadComment #10
joseph.olstadThanks everyone!