Problem/Motivation
Currently the ConfigurationItem class includes these properties:
/**
* Whether the configuration is provided by an extension.
*
* @var bool
*/
protected $extensionProvided = FALSE;
/**
* The providing feature.
*
* @var string
*/
protected $providingFeature;
However:
- We set
providingFeaturefor all extensions, not just features. - In core,
provideris used for a parallel case,EntityType::provider(). extensionProvidedis not strictly about whether the item is provided by an extension, but rather whether it has been explicitly excluded from packaging.
Proposed resolution
- Rename
ConfigurationItem::providingFeaturetoConfigurationItem::provider, and rename the corresponding getter and setter. Make appropriate changes to code documentation. - Rename
ConfigurationItem::extensionProvidedtoConfigurationItem::excludedand rename the corresponding getter and setter.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | features_rename_provider_excluded-2655286-4.patch | 9.02 KB | mpotter |
Comments
Comment #2
mpotter commentedThe tricky part of renaming ConfigurationItem::extensionProvided to ConfigurationItem::excluded is that "excluded" property already exists and is used when manually unchecking a config item in the edit form to "exclude" it. This isn't the same as the config excluded by the Exclude plugin.
Comment #3
mpotter commentedI'm going to rename ConfigurationItem::extensionProvided to ConfigurationItem::providerExcluded
This should help with the distinction that the config's "provider" was excluded by the Exclude plugin vs the specific config item being "excluded" in the UI.
Comment #4
mpotter commentedHere is a patch. Uses a global search so think this is good.
Comment #6
mpotter commentedCommitted this so I can improve some of the code in the AssignConfig a bit more. fc78c6b