Problem/Motivation

  • The file config/schema/features.schema.yml has a todo note and generally could use review.
  • The schema doesn't yet cover config/install/features.settings.yml.

features.settings.yml currently reads:

export:
  folder: 'custom'
langcode: en

Since there is only a single key within export, before writing a schema, we might consider converting this to:

export_folder: 'custom'
langcode: en

Proposed resolution

Remaining tasks

User interface changes

API changes

Comments

nedjo’s picture

Project: Configuration Packager » Features
Version: 8.x-1.x-dev » 8.x-3.x-dev
nedjo’s picture

Priority: Normal » Major
Status: Active » Postponed
Parent issue: » #2598332: [META] Blockers for 8.x BETA release
Related issues: +#2569149: Use ConfigEntity for features bundles

Setting as beta release blocker.

Postponing as it doesn't make much sense to do this ahead of the refactoring in #2569149: Use ConfigEntity for features bundles, which will the alter schema.

dawehner’s picture

Status: Postponed » Active

Someone can work on it now.

mpotter’s picture

Any takers on this one? I'd like to get the beta version out soon but don't have enough hours to get to this one this week.

nedjo’s picture

Issue summary: View changes
nedjo’s picture

Issue summary: View changes
mpotter’s picture

Probably would have been better to put the discussion of export_folder in a comment instead of editing the original topic just to make it easier to follow the issue history.

In any case, I think the original idea was "exports might have config options", and currently the only option is "folder". I'd rather leave it that way to make it easier to add other options in the future rather than going with export_folder.

I could also imagine something more general where the first key is the id of the generation plugin or something. I wouldn't go all the way like we did with assignment plugins and config entities, but the generation plugins might need a more general way to handle their settings.

mpotter’s picture

Status: Active » Needs review
StatusFileSize
new569 bytes

Patch for the features.settings

mpotter’s picture

Forgot the label for the Export settings

mpotter’s picture

Status: Needs review » Needs work

Using Input Filters in core as an example, it appears they *do* put plugin-specific config schema into the module. So marking this as "Needs Work" so I can go back and enter the schema for each plugin config.

mpotter’s picture

Priority: Major » Normal

Not going to finish this one in time for beta, but since we have a basic schema we can finish adding more post-beta.

mpotter’s picture

Status: Needs work » Needs review
StatusFileSize
new5.51 KB

Here is a patch that completes the configuration schema. Tested using config_inspector module. Bundles need to be re-saved to get correct boolean/integer/string types but the schema itself is correct.

  • mpotter committed c38a682 on 8.x-3.x
    Issue #2392561 by mpotter: Add configuration schema
    
mpotter’s picture

Status: Needs review » Fixed

Committed to c38a682.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.