Problem/Motivation
- The file config/schema/features.schema.yml has a todo note and generally could use review.
- The schema doesn't yet cover config/install/features.settings.yml.
features.settings.yml currently reads:
export:
folder: 'custom'
langcode: en
Since there is only a single key within export, before writing a schema, we might consider converting this to:
export_folder: 'custom'
langcode: en
Proposed resolution
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | features_add_configuration_schema-2392561-12.patch | 5.51 KB | mpotter |
| #9 | features_add_configuration_schema-2392561-9.patch | 601 bytes | mpotter |
| #8 | features_add_configuration_schema-2392561-8.patch | 569 bytes | mpotter |
Comments
Comment #1
nedjoComment #2
nedjoSetting as beta release blocker.
Postponing as it doesn't make much sense to do this ahead of the refactoring in #2569149: Use ConfigEntity for features bundles, which will the alter schema.
Comment #3
dawehnerSomeone can work on it now.
Comment #4
mpotter commentedAny takers on this one? I'd like to get the beta version out soon but don't have enough hours to get to this one this week.
Comment #5
nedjoComment #6
nedjoComment #7
mpotter commentedProbably would have been better to put the discussion of export_folder in a comment instead of editing the original topic just to make it easier to follow the issue history.
In any case, I think the original idea was "exports might have config options", and currently the only option is "folder". I'd rather leave it that way to make it easier to add other options in the future rather than going with export_folder.
I could also imagine something more general where the first key is the id of the generation plugin or something. I wouldn't go all the way like we did with assignment plugins and config entities, but the generation plugins might need a more general way to handle their settings.
Comment #8
mpotter commentedPatch for the features.settings
Comment #9
mpotter commentedForgot the label for the Export settings
Comment #10
mpotter commentedUsing Input Filters in core as an example, it appears they *do* put plugin-specific config schema into the module. So marking this as "Needs Work" so I can go back and enter the schema for each plugin config.
Comment #11
mpotter commentedNot going to finish this one in time for beta, but since we have a basic schema we can finish adding more post-beta.
Comment #12
mpotter commentedHere is a patch that completes the configuration schema. Tested using config_inspector module. Bundles need to be re-saved to get correct boolean/integer/string types but the schema itself is correct.
Comment #14
mpotter commentedCommitted to c38a682.