I just reviewed FBSS2FB to see what needs to be done to make it compatible with FBSS 3.x. I haven't tested it, but it looks to me like nothing needs to be changed -- it should just work with FBSS 3.x as-is. It would be great if someone could test this before we say affirmatively that this is the case, but just thought I'd let you know.

Also, I've attached a patch with a few minor things I noticed while reviewing the module:

  • The JS used 1 instead of 2 spaces for indenting
  • The JS callback page used "access content" for its access callback, but should have used "update status to Facebook" (though this is really just semantic)
  • The module allowed users with the "administer users" permission to see the setting to allow users to update their status to Facebook even if the viewed user didn't have permission to post their status to Facebook
  • The setting to allow a user to update their status to Facebook was always saved even if the user didn't have permission to see it (possible E_ALL error)
  • The pattern the Twitter integration uses in FBSS 3.x is to have the global setting on its own page instead of altering the admin form -- I just put in a TODO for this
  • Fixed indenting in fbss2fb_js()
  • Removed the "2.x required" note in the README

I should probably have broken these into separate issues, but it hardly seemed worth it...

CommentFileSizeAuthor
fbss2fb.patch3.65 KBicecreamyou

Comments

Anonymous’s picture

Hello,
I tried to apply the patch but it failed.

patching file fbss2fb.js
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file fbss2fb.js.rej
patching file fbss2fb.module
Hunk #1 FAILED at 17.
Hunk #2 FAILED at 38.
Hunk #3 FAILED at 68.
Hunk #4 FAILED at 76.
Hunk #5 FAILED at 118.
5 out of 5 hunks FAILED -- saving rejects to file fbss2fb.module.rej
patching file README.txt
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file README.txt.rej

brentratliff’s picture

@IceCreamYou,

I just saw that you are now recommending 3.x. I'll get this installed over the weekend and test it. Thanks again for taking a look. I'm going to give this module some time this week. I'm trying to get through some other priorities. Thanks for everyone's patience.

brentratliff’s picture

The patch also failed for me with git apply -v since it's not a git patch. I was able to commit it with TextMate successfully using the Diff Bundle. The patch command should also work on the CLI. I'm testing it now and if there are no issues, I'll go ahead and commit. Thanks @IceCreamYou.

icecreamyou’s picture

Ah, crap, I didn't realize git patches have a different format. That would explain a lot. Guess I need to find a Windows tool that can do git patches then (I use a GUI client normally that can't).

brentratliff’s picture

I haven't tried it, but NetBeans with the Git plugin should generate a Git patch.

brentratliff’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jmonster’s picture

Sorry have to reopen this but I'm having a difficult time getting this to work. I have gone through the steps on fb module and yes all 3 fb mod required mods are on. Upgrading procedure done although it never did work the first time. Everything else works fine with that module, but posting status' just won't work. I'm using fbss2fb 1.x dev with fb 3.x fbss 3.x.

Is the fbss 3.x really compatible with the fbss2fb 1.x module because this thread ended up in dead air. Am thinking of reverting back to fbss 2.x but that's just a big headache as will need to unistall first. Please assist

jmonster’s picture

Status: Closed (fixed) » Active

Reopening

brentratliff’s picture

I'm going to be rewriting this module almost completely in the next couple weeks to ensure better reliability, especially with 3.x. My goal is to remove the Javascript action and use the FB PHP library instead.

jmonster’s picture

Alright will just have to wait then. Thanks

brentratliff’s picture

If you're brave, I may be committing some initial code early next week. I definitely don't recommend it on production sites. I had good success with http://drupal.org/project/fbss_linkedin using this method and I'm hoping I can adapt it to Drupal for Facebook.

brentratliff’s picture

I've committed the new 3.x branch that will work with FBSS 3.x. It's not ready but you can test it if your site doesn't have live users yet. It only works for newly created users as it will prompt them for extended permissions when they first connect their account. I'm adding the logic in this week so that current users will be prompted the first time they try to post to FB.

brentratliff’s picture

This is ready for testing and should work. You need enable the Extended Permission submodule of Drupal for Facebook and check "Publish to my Wall'. The next time your users logon, they will be asked to grant the permission. They should then be able to post.

Anonymous’s picture

It works fine with the latest dev release. Thank you very much !

brentratliff’s picture

Status: Active » Fixed

Marking fixed. @jmonster, feel free to reopen if you are having issues with the 3.x dev release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.