catch a failed include

Patch included.

You can apply it manually or automatically.

Manually
If you read the patch you see changes are in fb.module and on line 419 (I'm not sure if it's the line where function fb_api_init($fb_app) { is or the line what you need to replace but anyways look there). Look for what lines have - and +. - states what was removed and + states what the removed line was replaced with.

Automatically
You need to have git repository set up for this module first (7.x-3.x-dev as written above my first post). So here http://drupal.org/project/fb/git-instructions choose 7.x.3.x and execute the git command written below. It's
git clone --recursive --branch 7.x-3.x http://git.drupal.org/project/fb.git
for fb module. Copy patch into fb module dir. Finally execute
git apply fb-catch_a_failed_include-1804172-1.patch
or
git am fb-catch_a_failed_include-1804172-1.patch
Both commands apply patch but are somewhat different. Here's a more in-depth help: http://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git or try just http://www.google.ee/search?q=apply+patch+git&aq=f&sugexp=chrome,mod=1&s...

Maby you want to create a patch yourself. First linke here http://www.google.ee/search?q=apply+patch+drupa&sugexp=chrome,mod=1&sour... tells you how. In short it's it's
git diff > [project_name]-[short_description]-[issue-number]-[comment-number].patch

Good to know!

I rewrote the tests to see what we could do better in fb.module. I managed to get 4x better results if is_file was used.

Check it out yourself.

function no_suppress() {
  $fb_platform = 'i_dont_exist';
  if (!(is_file($fb_platform) && include($fb_platform) && class_exists('Facebook'))) {
  }
}

function suppress() {
  $fb_platform = 'i_dont_exist';
  if (!class_exists('Facebook') && !@include($fb_platform)) {

  }
}

function do_test($suppress = false, $loops = 1000000) {
    if($suppress) {
        echo "starting suppress...\n";
        $start = microtime(true);
        for($i = 0; $i < $loops; $i++) {
            suppress();
        }
        $end = microtime(true);
    } else {
        echo "starting no_suppress...\n";
        $start = microtime(true);
        for($i = 0; $i < $loops; $i++) {
            no_suppress(true);
        }
        $end = microtime(true);
    }
    echo "ended: " . ($end - $start) . "\n";
}

do_test(1, 20000);
echo '<br>';
do_test(0, 20000);

Didn't have time to test it on fb.module

Good point!

I didn't get any loss in speed when clearstatcache() was enabled. Not on server or my pc.

clearstatcache() enabled:
starting suppress... ended: 23.215982913971
starting no_suppress... ended: 1.550351858139

clearstatcache() disabled:
starting suppress... ended: 27.163813114166
starting no_suppress... ended: 1.5654368400574

Last tests were run on my pc and 20 000 times. Current tests were run 1 000 000 time and on server.

At some runs suppressed result got even 56.331800222397 when no_suppress was always under 2.

I guess error throwing really is as bad as it's said.

function no_suppress() {
  $fb_platform = 'i_dont_exist';
  clearstatcache();
  if (!(is_file($fb_platform) && include($fb_platform) && class_exists('Facebook'))) {
  }
}

function suppress() {
  $fb_platform = 'i_dont_exist';
  if (!class_exists('Facebook') && !@include($fb_platform)) {

  }
}

function do_test($suppress = false, $loops = 1000000) {
    if($suppress) {
        echo "starting suppress...\n";
        $start = microtime(true);
        for($i = 0; $i < $loops; $i++) {
            suppress();
        }
        $end = microtime(true);
    } else {
        echo "starting no_suppress...\n";
        $start = microtime(true);
        for($i = 0; $i < $loops; $i++) {
            no_suppress(true);
        }
        $end = microtime(true);
    }
    echo "ended: " . ($end - $start) . "\n";
}

do_test(1);
echo '<br>';
do_test(0);

Patch attached. I also fixed the error repeat (although weird that it's called twice).