Hello,

Thanks for the great module! I hope development will continue in the future.

I am working on a view of recent comments on our forum. I would like to be able to include the fasttoggle links on this view. I can do this if I set the view type to comments instead of fields, but there are some other fields that I would like to add (e.g. this view isn't that useful without a link to the node). I notice that the fasttoggle links are available as fields for nodes - can this be added for comments as well?

Currently running Drupal 6.16 and fasttoggle 6.x-1.3.

Thanks a lot!!

CommentFileSizeAuthor
#3 799086_fasttoggle_views_intergration.patch3.47 KBhefox

Comments

Fidelix’s picture

Fidelix commented

This would be great for comment moderation screen...

hefox’s picture

hefox commented
Title: Views integration for comments » Views integration for comments/users
Assigned: Unassigned » hefox

Working on this

hefox’s picture

hefox commented
Assigned: hefox » Unassigned
Status: Active » Needs review
StatusFileSize
new 799086_fasttoggle_views_intergration.patch3.47 KB
Fidelix’s picture

Fidelix commented

hefox, thank you for working on this.

What is this patch currently doing? I don't see anything new on "Comments" section of my view fields.

hefox’s picture

hefox commented

Clear cache then look for "Publish Link (Fasttoggle)" in comments fields

Fidelix’s picture

Fidelix commented

I'm sorry, but I applied the patch with patch -p0 < patch.799086_fasttoggle_views_intergration.patch and got this message:

Hunk #1 FAILED at 38.
Hunk #2 FAILED at 52.
2 out of 2 hunks FAILED -- saving rejects to file b/views/fasttoggle.views.inc.rej
patching file b/views/fasttoggle_views_handler_field_comment_link.inc
patching file b/views/fasttoggle_views_handler_field_user_link.inc

Then, applied it with -p1, and

patching file views/fasttoggle.views.inc
patching file views/fasttoggle_views_handler_field_comment_link.inc
patching file views/fasttoggle_views_handler_field_user_link.inc

cleared the cache, and this field isn't appearing.

hefox’s picture

hefox commented

If the patch has a/, b/ for the paths in it, this is the new standard format and no -p is needed, just use patch < patch file.

Can you verify that there is new items in fasttoggle.views.inc? And that the two new files were added? That might be the issue

Fidelix’s picture

Fidelix commented 
sites/all/modules/fasttoggle# patch < 799086_fasttoggle_views_intergration.patch 
patching file fasttoggle.views.inc
Hunk #1 FAILED at 38.
Hunk #2 FAILED at 52.
2 out of 2 hunks FAILED -- saving rejects to file fasttoggle.views.inc.rej
patching file fasttoggle_views_handler_field_comment_link.inc
patching file fasttoggle_views_handler_field_user_link.inc

BTW, I'm using 6.x-1.x-dev

hefox’s picture

hefox commented

Are you using the latest 6.x-1.x-dev? edit: didn't see note at bottom, but yea, latest code?

Patches are actually easy to manually reply; you can look at patch and guess why it's not applying.

Fidelix’s picture

Fidelix commented 
rm -rf fasttoggle/;git clone --branch 6.x-1.x http://git.drupal.org/project/fasttoggle.git
Cloning into fasttoggle...
sites/all/modules# cd fasttoggle
sites/all/modules/fasttoggle# wget http://drupal.org/files/799086_fasttoggle_views_intergration.patch
sites/all/modules/fasttoggle# patch < 799086_fasttoggle_views_intergration.patch 
patching file fasttoggle.views.inc
Hunk #1 FAILED at 38.
Hunk #2 FAILED at 52.
2 out of 2 hunks FAILED -- saving rejects to file fasttoggle.views.inc.rej
patching file fasttoggle_views_handler_field_comment_link.inc
patching file fasttoggle_views_handler_field_user_link.inc
sites/all/modules/fasttoggle# drush cc all

No luck.
Deleted everything, git clone again, applied the stuff in the patch manually, drush cc all, still no luck.

killes@www.drop.org’s picture

killes@www.drop.org commented

I was able to apply this patch to the latest stable version (6.x-1.4). Seems to work great.

nigelcunningham’s picture

nigelcunningham commented
Status: Needs review » Fixed

Sorry for the delay in acting on this and thanks for the prod (Gerhard) to look at my issue queue.

Patch committed to git. I'll look to see if there are other patches that can be applied before rolling a new stable release.

killes@www.drop.org’s picture

killes@www.drop.org commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.