I have a date facet working on the created property for nodes looking something like this:
If I first click on "June 20, 2012" everything is fine. But when I try to narrow down on "10 AM" it doesn't give the intended result back.
The problem does not occur when disabling facetapi_pretty_paths.module.
When the module is traversing all segments it does so from right to left (to find the search base path last). It turns out that the order we add filters in, is important for some facets. I think this is a general problem and nothing specific to date facets, like in my case.
So we have to reverse the filters when re-assigning them to $_GET. The attached patch (very simple) fixes the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | Search | Smartphone compare-4.jpg | 61.57 KB | nick_vh |
| #8 | Search | Smartphone compare-5.jpg | 44.05 KB | nick_vh |
| #7 | Search | Smartphone compare-3.jpg | 90.64 KB | nick_vh |
| #4 | Search | Smartphone compare-1.jpg | 92.09 KB | nick_vh |
| #3 | 1648582-3.patch | 1.53 KB | nick_vh |
Comments
Comment #1
dasjonice one, sounds good, thank you for reporting and proposing the fix!
i hope i can test it soon, if others want to speed up the process feel free to review and set to RTBC if appropriate :)
Comment #2
nick_vhThis patch does not seem to work for me, I'm looking into the possible problems
The facet never gets selected as active at all.
Comment #3
nick_vhDiscovered that the alias was used and in some cases the field. We should never use the alias, since this can be different compared to the field that is used.
The reversing of the params is also very crucial in this patch (thx dixon_), because the facet will go bezerk otherwise
Comment #4
nick_vhobligatory picture to prove that everything is still working.
Renamed ds_created in the url to postdate, so the alias is still working
Comment #5
nick_vh#1642140-8: Make the search query also escape the slash and move away from menu_tail to just 1 argument Swentel confirms that this patch is required to make it all work. Any change of getting this tested with Search API? If someone can confirm that this patch does not hurt Search API, it's RTBC.
Comment #6
nick_vhSo we only have the reverse again. It looks like this is breaking the breadcrumb order. The alias issue was committed #1650522: Alias wrongly used in certain context
Comment #7
nick_vhConfirmation that breadcrumbs are ordered in wrong direction with this array_reverse. But without it, the facet ordering in the blocks are not ok.
Comment #8
nick_vhWithout patch :
With patch :
Comment #9
dasjocommitted, thanks! http://drupalcode.org/project/facetapi_pretty_paths.git/commit/03207f5
note, that i did some follow up work related, like http://drupalcode.org/project/facetapi_pretty_paths.git/commit/dc2d815