Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 facebook_pixel-add-config-translation-3322237-2.patch1.66 KBglauberjs
#2 facebook_pixel-add-config-translation-3322237-1.patch408 bytesglauberjs
facebook_pixel-add-config-translation.patch408 bytesglauberjs

Comments

glauberjs created an issue. See original summary.

glauberjs’s picture

glauberjs commented
StatusFileSize
new facebook_pixel-add-config-translation-3322237-1.patch408 bytes
glauberjs’s picture

glauberjs commented
Component: Code (Facebook Pixel) » Code (General)
glauberjs’s picture

glauberjs commented
Status: Active » Needs review
glauberjs’s picture

glauberjs commented
glauberjs’s picture

glauberjs commented
glauberjs’s picture

glauberjs commented
glauberjs’s picture

glauberjs commented
glauberjs’s picture

glauberjs commented
StatusFileSize
new facebook_pixel-add-config-translation-3322237-2.patch1.66 KB

Apply path for fix error: Warning: foreach() argument must be of type array|object, null given in Drupal\config_translation\Form\ConfigTranslationFormBase->submitForm() (line 201 of core/modules/config_translation/src/Form/ConfigTranslationFormBase.php).

grevil’s picture

grevil commented
Version: 2.0.0-rc3 » 2.x-dev
Status: Needs review » Needs work
grevil’s picture

grevil commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: -#ciandt-contrib

What exact part of the config do you need to translate?

The facebook_id as well as the visibility settings should NEVER be translated, as adding translation to these configs will lead to broken functionality / broken path variables. All privacy settings texts are translatable, so this also shouldn't be a problem.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: glauberjs » Unassigned
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Agree with @Grevil and changing string to text would also be wrong. Should instead be label then, but makes no sense to translate these technical values.

Setting won't fix until good reasons are given. I can't see any yet.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

BTW please take the time to create a proper issue summary. This is a mess.

glauberjs’s picture

glauberjs commented

In the context of the project I work on, the translation is carried out for a country in question, so for each country, it has a different facebook id, which is why I had to change it to text.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks for the feedback @glauberjs. I still don't think this is a proper reason for "translation" for technical settings. Core and other modules also don't do this.

Perhaps this: https://www.drupal.org/project/config_override is what you want or you need custom code for such overrides.
Also see https://www.drupal.org/docs/drupal-apis/configuration-api/configuration-...

I don't think we will ever commit / merge this. I hope you can understand the reasons.

glauberjs’s picture

glauberjs commented

Thanks Anybody!!