The module does not work with links that are in area tags.

This patch causes extlink to also apply to links that reside within area tags.

CommentFileSizeAuthor
#2 extlink_area_tag.2.patch1.13 KBsutch
extlink_area_tag.patch995 bytessutch

Comments

quicksketch’s picture

quicksketch
he/him
commented

Is there any difference in the logic between anchor tags and areas? Maybe we could just add area to the existing selector rather than duplicate all the code in two places.

sutch’s picture

sutch commented
StatusFileSize
new extlink_area_tag.2.patch1.13 KB

There is a bit of logic difference between anchor tags and area tags. Area tags containing mailto: links should not be updated by the script (i.e., no icons should be added to these links when part of an image map).

I've followed your suggestion and used the existing existing selector to also catch area tags and to not update the mailto: links.

timwood’s picture

timwood
Primary language English
Location Rockville, Maryland
commented
Status: Needs review » Reviewed & tested by the community

We've tested this and it appears to be working correctly! Thanks sutch!

quicksketch’s picture

quicksketch
he/him
commented
Category: bug » feature
Status: Reviewed & tested by the community » Fixed

Thanks guys, committed as is. New version (1.12) coming your way soon!

Status: Fixed » Closed (fixed)
Issue tags: -image-map area

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +image-map area

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.