Problem/Motivation

Thank you soooo much for this great module! I love it :)

Just one thing I was missing in several projects: Being able to configure classes to add on detected external / mail links.
That would be super helpfol to "mark" these kind of links for other JS tasks or CSS consistently.

Steps to reproduce

Proposed resolution

Add a setting
"Add custom CSS classes" (boolean)
and if enabled show a textfield "Custom CSS classes" where CSS classes can be configured, separated by comma, which are applied to the detected links.

That should be super helpful and flexible!

What do you think?

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork extlink-3333202

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

lrwebks’s picture

lrwebks commented
Assigned: Unassigned » lrwebks
Status: Active » Needs work

Let's start with this one! Definitely doable in a timely manner.

LRWebks opened merge request !9

lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review

After a whole lot of work this is finally up and running! To review it is!

lrwebks’s picture

lrwebks commented
Status: Needs review » Needs work
lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review

This time we might be done!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Just some final alignments.

Please also add tests like the module already has.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review
lrwebks’s picture

lrwebks commented

With all of it working out fine now, I hope that was the last from me! :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: lrwebks » Unassigned
Status: Needs review » Reviewed & tested by the community

Well done! Nice and helpful feature!

  • Anybody committed 502b3ae8 on 8.x-1.x authored by LRWebks 
    Issue #3333202 by LRWebks, Anybody: Allow to add classes for external...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Merged! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

This issue had a hook_update that referenced non-existent config options. I've opened #3467662: extlink_update_8103 for mailto & ext links define a non-used setting to fix the update hook. An MR is posted over there.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Ouch, thank you @heddn. No idea why I didn't see that! -.-