Closed (fixed)
Project:
External Links
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Oct 2013 at 23:02 UTC
Updated:
30 Apr 2014 at 23:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
elachlan commentedThe code in question:
Both
$.supportand$.browserare either deprecated or no longer advised to be used. This peice of code is used because of box model problems in ie 7 and below see http://en.wikipedia.org/wiki/Internet_Explorer_box_model_bug.This post says that you should force it using the doctype, which would mean we could remove that code and just tell people to avoid quirks mode.
http://stackoverflow.com/questions/4007866/how-to-solve-ie6-box-model-pr...
For reference, here is the previous issue #795360: Mailto and Extlink images not showing.
Comment #2
elachlan commentedComment #3
elachlan commentedComment #4
elachlan commentedFirst patch.
Removed the offending line.
Based off of feedback from a previous issue, we are going to avoid support for anything below IE8.
This will need lots of testing.
Comment #6
elachlan commentedVersion needs to be DEV to test against latest changes.
Comment #7
elachlan commented4: extlink-2124457-1.patch queued for re-testing.
Comment #8
duntuk commentedFYI, 4: extlink-2124457-1.patch works. Tested on DEV.
Comment #9
quicksketchLooks like this wasn't applied to the 7.x-1.x branch, so I committed it there as well. Thanks guys!