Use theme('image', rather than theme_image(

Good find, this definitely needs to be fixed.

+++ extlink.moduleundefined
@@ -43,7 +43,7 @@ function extlink_admin_settings() {
+    '#description' => t('Places an !icon icon next to external links.', array('!icon' => theme('image',array('path' => drupal_get_path('module', 'extlink') .'/extlink.png', 'alt' => t('External Links icon'), 'attributes' => array())))),

You can safely remove 'attributes' => array() now that this is using the proper theme function.

Also, we're missing a space after a comma, and a concatenating period.

+++ extlink.moduleundefined
@@ -52,10 +52,10 @@ function extlink_admin_settings() {
-      '!icon' => theme_image(array(
+      '!icon' => theme('image',array(
         'path' => drupal_get_path('module', 'extlink') . '/mailto.png',
         'alt' => t('Email links icon'),
-        'attributes' => '',
+        'attributes' => array(),
       )),
     )),
   );

Needs to be a space in between 'image', and array(

+++ extlink.moduleundefined
@@ -52,10 +52,10 @@ function extlink_admin_settings() {
-        'attributes' => '',
+        'attributes' => array(),
       )),
     )),
   );

Same here about removing 'attributes' => array().

Powered by Dreditor.

Weird, I wonder what I was thinking here.

LoL XD

Patch hasn't destroyed my site and the icons are still iconing and external links are still opening in new tabs/windows :)

Thanks, committed. Backported a similar change to D6.