The version of node_access_example.module for Drupal 6 that is currently publicly available ("Version 1.1 (checked in on 2009/10/03 at 14:35:27 by rfay)") appears to be for the Drupal 7 API instead of for the Drupal 6 API (in D6, there is only one hook_nodeapi() instead of a hook for each operation). This is very mis-leading for newbies and makes it difficult to understand how to write a node access module for Drupal 6.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | examples.node_access_example_for_drupal_6.patch | 3.7 KB | rfay |
| #7 | 791144-node-access-example-rollback.patch | 4.25 KB | dave reid |
| #6 | 791144-node-access-example-rollback.patch | 4.19 KB | dave reid |
Comments
Comment #1
rfayYou're surely right. Let's see if we can sort this out.
Comment #2
jhodgdonMoving to correct queue
Comment #3
rfayActually, I'm not able to figure out what you mean - please help me.
The D6 version of the node_access_example.module in http://drupal.org/project/examples has hook_perm(), the D6 version.
The version on the API site: http://api.drupal.org/api/drupal/developer--examples--node_access_exampl..., has hook_perm(), the D6 version.
Can you help me understand with some links or something? Or perhaps the API site had a glitch?
I should mention too, @Guy, that your participation here is welcome. Patches are solicited. And the node_access.module needs an update to D7 (and probably other help). And it needs tests.
Comment #4
rfayMarked #786464: node_access_example_perm() returns wrong format as a dup of this one.
Comment #5
rfayOK, so it has hook_perm(), but it has it in the D7 format. And all the rest of your comments are right.
We've never even worked on this one, but somehow got a partially-converted D7 version in here in the initial copy. I'm not even sure if we have the original D6 version around now, so perhaps will have to work backward. Use the private module?
Comment #6
dave reidHere's the relevant rollback to the latest version that was in contributions/docs/examples.
Comment #7
dave reidBetter patch with a few cleanups.
Comment #8
rfayWith slight changes, and now it works - one more D7-ism removed.
Thanks so much for the archaelogy, davereid. Finally we get this cleaned up.
It still needs tests and a going-over, but at least it won't be there just confusing people any more.
Comment #9
rfayWow, thanks Dave. Finally got this cleaned up. Committed to DRUPAL-6--1
http://drupal.org/cvs?commit=405846