Both Drupal\Tests\examples\Unit\RoutePathTest and Drupal\Tests\examples\Unit\YamlValidationTest implement the same data provider, which has been changed as per #3458387: YamlValidationTest::provideYamls() returns .yml files that are not part of the Examples project and which could still need to be changed in future.

If those classes use the same parent class, the part of the data provider which could need to be changed would be put in a single file.

Issue fork examples-3458487

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

apaderno created an issue. See original summary.

avpaderno’s picture

Issue tags: -Create a trait for provideYamls() used by YamlValidationTest and RoutePathTest
avpaderno’s picture

Title: Create a trait for provideYamls() used by RoutePathTest and YamlValidationTest » Create a parent class for RoutePathTest and YamlValidationTest
Issue summary: View changes

avpaderno’s picture

Status: Active » Needs review

  • apaderno committed 0b4de014 on 4.0.x
    Issue #3458487: Create a parent class for RoutePathTest and...
avpaderno’s picture

Status: Needs review » Fixed

  • apaderno committed 10dba275 on 4.0.x
    Follow-up to #3458487: Made the code more generic by using traits; added...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.