Problem/Motivation

At #3417482: [Meta] Pass Eslint validations we are aiming to have all the eslint validation checks passing for the Examples module.

On this issue, we'll be focused on the plugin_type_example sub-module

Initial errors detected by 27/01/2024

modules/plugin_type_example/plugin_type_example.services.yml
  6:3  error  Expected line before comment  lines-around-comment
  9:5  error  Expected line before comment  lines-around-comment

Proposed resolution

  1. Check the parent issue for detailed instructions about how to run eslint locally
  2. Run eslint against the submodule: plugin_type_example
  3. Fix the issues found and make a MR with the fixes.

Issue fork examples-3417508

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jlbellido created an issue. See original summary.

tyler36 made their first commit to this issue’s fork.

tyler36 opened merge request !37

tyler36’s picture

tyler36 commented
Status: Active » Needs review
tyler36’s picture

tyler36 commented

Tests are failing due to un-related issue.

apaderno made their first commit to this issue’s fork.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Pass Eslint validations: Plugin type example » Pass Eslint validations: Plugin Type Example

  • apaderno committed a94c680d on 4.0.x authored by tyler36 
    Issue #3417508: Fix the ESLint errors reported for the Plugin Type...
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Pass Eslint validations: Plugin Type Example » Pass ESLint validations: Plugin Type Example
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.