Problem/Motivation

  1. Coding standards checking does not pass
  2. TableSortExampleTest and TourExampleTest do not pass
  3. Deprecation notice: Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0

Proposed resolution

The patch from #3092947: Getting error when module is enabled. can fix the TableSortExampleTest and TourExampleTest

CommentFileSizeAuthor
#3 tablesort-and-tour-3103548-3.patch3.05 KBjungle
#2 tablesort_example-3103548-2.patch2.56 KBjungle

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Assigned: jungle » Unassigned
Status: Active » Needs review
Related issues: +#3103518: Deprecation notices: Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0, +#3092947: Getting error when module is enabled.
StatusFileSize
new tablesort_example-3103548-2.patch2.56 KB
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Title: Tidy up tablesort_example » Tidy up tablesort_example and tour_example
Issue summary: View changes
StatusFileSize
new tablesort-and-tour-3103548-3.patch3.05 KB

Put tour_example together here, as it depends on the patch from #3092947: Getting error when module is enabled. as well

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Version: 8.x-1.x-dev » 3.x-dev
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Closed (won't fix)

Wrong scope, closing