Problem/Motivation

All submodules are at the top level of the module, It looks a little bit messy. BTW, the commerce module did put all submodules into a subfolder called modules.

Proposed resolution

It's easy to get it done without a patch attached. The agreement from maintainers and you are needed.

CommentFileSizeAuthor
#9 3103520-9.patch104.92 KBjungle
#5 3103520-5.patch103.96 KBjungle

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Active » Needs review

As the patch is optional, I'd change the status to Needs review

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Version: 8.x-1.x-dev » 3.x-dev
Assigned: Unassigned » jungle
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Postponed
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Assigned: jungle » Unassigned
Status: Postponed » Needs review
StatusFileSize
new 3103520-5.patch103.96 KB

Moving all sub-modules into folder modules

Status: Needs review » Needs work

The last submitted patch, 5: 3103520-5.patch, failed testing. View results

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs work » Needs review

Requeued

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Needs work

6 coding standards messages

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
StatusFileSize
new 3103520-9.patch104.92 KB

Removing custom .drupalci.yml to see how bot thinks.

jungle credited andypost.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

Crediting @andypost for discussions with me on slack.

  • jungle committed aaddeec on 3.x 
    Issue #3103520 by jungle, andypost: Move all examples/submodules into...
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Version: 3.x-dev » 8.x-1.x-dev
Status: Needs work » Patch (to be ported)

Not sure this should be ported to 8.1.x, needs discussing with other maintainers.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Patch (to be ported) » Fixed

@jungle: Should it go to 8.1.x?
@andypost: no, let's keep it frozen, except maybe removing 9.x support

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.