------ ----------------------------------------------------------------------
Line testing_example/tests/src/Functional/TestingExampleMenuTest.php
------ ----------------------------------------------------------------------
46 Method Drupal\Tests\BrowserTestBase::assertResponse() invoked with 2
parameters, 1 required.
------ ----------------------------------------------------------------------

CommentFileSizeAuthor
#7 fix_deprecations-3072451-7.patch2.77 KBalt.dev
#2 testing_example.patch588 bytestrishen
testing_example.patch0 bytestrishen

Comments

trishen created an issue. See original summary.

trishen’s picture

trishen commented
StatusFileSize
new testing_example.patch588 bytes
dpovshed’s picture

dpovshed commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +KharkivCS

Patch looks fine

  • valthebald committed c0a2c82 on 8.x-1.x 
    Issue #3072451 by trishen, dpovshed: testing_example fix code to allow...
valthebald’s picture

valthebald
Location Sofia
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x, thank you all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alt.dev’s picture

alt.dev commented
StatusFileSize
new fix_deprecations-3072451-7.patch2.77 KB

The Drupal 8.8 branch got new deprecations.

 ------ ---------------------------------------------------------------------------------
  Line   testing_example/src/Tests/NaiveConversionTest.php
 ------ ---------------------------------------------------------------------------------
  17     Class Drupal\testing_example\Tests\NaiveConversionTest extends deprecated class
         Drupal\simpletest\WebTestBase:
         in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ ---------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------
  Line   testing_example/src/Tests/SimpleTestExampleMockModuleTest.php
 ------ ---------------------------------------------------------------------------------------------
  32     Class Drupal\testing_example\Tests\SimpleTestExampleMockModuleTest extends deprecated class
         Drupal\simpletest\WebTestBase:
         in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ ---------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------
  Line   testing_example/src/Tests/SimpleTestExampleTest.php
 ------ -----------------------------------------------------------------------------------
  31     Class Drupal\testing_example\Tests\SimpleTestExampleTest extends deprecated class
         Drupal\simpletest\WebTestBase:
         in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ -----------------------------------------------------------------------------------

I attach the patch which fixes those errors. This patch should be committed when the Drupal 8.8 branch will be released.