According to coding standard checker, direct dsm() call is discouraged.

- dumper (as service) should be injected via setter, other constructor arguments cleaned as it changes
- form depends only on file storage (not entity type manager)
- forms should use request object via buildForm() instead of request stack

CommentFileSizeAuthor
#6 interdiff.txt1.37 KBandypost
#6 3072425-6.patch7.38 KBandypost
#4 3072425-4.patch6.62 KBandypost
replace-direct-dsm-call.patch999 bytesdpovshed

Comments

dpovshed created an issue. See original summary.

dpovshed’s picture

dpovshed commented
Assigned: dpovshed » Unassigned
EgorSolocnhenko’s picture

EgorSolocnhenko commented

This issue is fixed here https://www.drupal.org/project/examples/issues/3072438

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Replace dsm() call » Replace dsm() call in file_example/src/Form/FileExampleReadWriteForm.php
Issue summary: View changes
StatusFileSize
new 3072425-4.patch6.62 KB

This change require change of constructor to show proper usage of DI

I will repurpose #3072438: file_example fix verbose() usage tests to verbose fix

Status: Needs review » Needs work

The last submitted patch, 4: 3072425-4.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 3072425-6.patch7.38 KB
new interdiff.txt1.37 KB

Nice to see that we have test coverage here, fixed + minor code-style clean-ups

goodboy’s picture

goodboy commented
Status: Needs review » Reviewed & tested by the community

I checked everything and did not find errors.
+1 to RTBC

  • valthebald committed 6f1accb on 8.x-1.x 
    Issue #3072425 by andypost, dpovshed, goodboy, valthebald: Replace dsm...
valthebald’s picture

valthebald
Location Sofia
commented

Committed to 8.x-1.x, thank you!

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.