Problem/Motivation

SafeMarkup methods are deprecated: https://www.drupal.org/node/2549395

These are used in dbtng_example and email_example.

Proposed resolution

Remove usages of these methods.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 2975898_10.patch1.92 KBmile23
#8 interdiff_2975898-5-8.txt1.89 KBeli-on-drupal
#8 2975898-8.patch1.92 KBeli-on-drupal
#5 2975898-5.patch1.92 KBeli-on-drupal

Comments

Mile23 created an issue. See original summary.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Title: Remove usages of SafeMarkup methods » Remove usages of @deprecated SafeMarkup methods
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Priority: Normal » Major

Setting this to major since CI runs against core 8.6.x tell us that we'll start failing tests soon: https://www.drupal.org/pift-ci-job/1009453

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Title: Remove usages of @deprecated SafeMarkup methods » Remove usages of @deprecated SafeMarkup methods (8.6.0)
eli-on-drupal’s picture

eli-on-drupal commented
StatusFileSize
new 2975898-5.patch1.92 KB

In this patch, I changed the deprecated methods to the recommended replacements.

eli-on-drupal’s picture

eli-on-drupal commented
Status: Active » Needs review

Changing to needs review for tests.

Status: Needs review » Needs work

The last submitted patch, 5: 2975898-5.patch, failed testing. View results

eli-on-drupal’s picture

eli-on-drupal commented
Status: Needs work » Needs review
StatusFileSize
new 2975898-8.patch1.92 KB
new interdiff_2975898-5-8.txt1.89 KB

Second attempt, with proper capitalization to hopefully pass test.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Parent issue: » #2992455: [meta] 8.7.0 deprecation changes
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
StatusFileSize
new 2975898_10.patch1.92 KB

Reroll.

Status: Needs review » Needs work

The last submitted patch, 10: 2975898_10.patch, failed testing. View results

  • marvil07 committed 0e0ca68 on 8.x-1.x authored by Mile23 
    Issue #2975898 by eliclaggett, Mile23: Remove usages of @deprecated...
marvil07’s picture

marvil07 commented
Status: Needs work » Fixed

Change looks good, added to mainline.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

@marvil07++

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.