Closed (fixed)
Project:
Examples for Developers
Version:
8.x-1.x-dev
Component:
Javascript Example
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2013 at 03:35 UTC
Updated:
22 Jan 2014 at 22:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
vijaycs85Initial patch...
Tested locally and working like D7.
Comment #2
mile23Thanks, vijaycs85. Looks like a great start.
Lets rename this thing to be 'JavaScript Example.'
A few references to Drupal 7.
Let's follow the other examples and use a path of /examples/js_example/whatever.
Also, we need a route and controller for /examples/js_example, with a little bit of explanation of what's going on.
Overall it would be good to have more inline comments and docblocks explaining the code.
Thanks.
Comment #3
vijaycs85Thanks for the review @Mile23. Here is the updates.
#2.1 - FIXED
#2.2 - FIXED
#2.3 - FIXED
#2.3.1 - NOT-FIXED: "Also, we need a route and controller for /examples/js_example, with a little bit of explanation of what's going on." - Not sure what really we need to have on that page.
#2.3.2 - NOT-FIXED: "inline comments and docblocks explaining the code" - Again not sure what needs to be covered.
Comment #4
mile233: 2102665-js_example-convert-d8-3.patch queued for re-testing.
Comment #6
mile233: 2102665-js_example-convert-d8-3.patch queued for re-testing.
Comment #7
mile23Added info page, fixed some routing stuff, added menu items, expanded some inline comments, added a few @ingroups, now tests for the existence of paths for some regression value.
Comment #8
mile23And... committed. http://drupalcode.org/project/examples.git/commitdiff/87b72912d34bca5dd5...
Thanks, vijaycs85!
Comment #9
vijaycs85yay!!! thank you too @Mile23