Sub-issue for meta issue #1880976: [meta] Port examples (including submodules) to D9.4+

Problem/Motivation

D8 all the things!

See: #2277629: Add filter example

Proposed resolution

Start with D7 version and figure out how to port ;)

CommentFileSizeAuthor
#3 examples-filter_d8-2102657-2.diff2.36 KBGarrett Albright
#1 examples-filter_d8-2102657-1.patch12.12 KBGarrett Albright
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Garrett Albright’s picture

Garrett Albright CreditAttribution: Garrett Albright commented
FileSize
examples-filter_d8-2102657-1.patch12.12 KB

Port of the filters and the tests (which pass, even). hook_help() and hook_menu() stuff not yet included.

Garrett Albright’s picture

Garrett Albright CreditAttribution: Garrett Albright commented
Status: Active » Needs work
Garrett Albright’s picture

Garrett Albright CreditAttribution: Garrett Albright commented
Status: Needs work » Needs review
FileSize
examples-filter_d8-2102657-2.diff2.36 KB

And here it is with hook_help().

Assuming we can neglect the stuff that hook_menu() was doing (see my post in the D8 port meta-thread about that), this should be complete now.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

Pretty sure we can't neglect what hook_menu was doing. :-)

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Issue summary: View changes
Status: Needs review » Needs work

Testbot makes me unhappy.

Garrett Albright’s picture

Garrett Albright CreditAttribution: Garrett Albright commented

Huh?

zealfire’s picture

zealfire CreditAttribution: zealfire commented
Assigned: Unassigned » zealfire
Status: Needs work » Active

I would love to work on this starting from the beginning.

zealfire’s picture

zealfire CreditAttribution: zealfire commented
Assigned: zealfire » Unassigned
zealfire’s picture

zealfire CreditAttribution: zealfire commented

This need a lot of work to be done as Drupal 8 uses plugins.Also the tests need to be written from start. Will try to make a sandbox project and proceed further.

zealfire’s picture

zealfire CreditAttribution: zealfire commented
Assigned: Unassigned » zealfire

All the development related to this issue is being done over here: https://www.drupal.org/sandbox/zealfire/2444489

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Assigned: zealfire » Unassigned

Generally unassigning issues. Please re-assign yourself as desired.

navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commented
Issue summary: View changes

This can be marked duplicate or closed in favour of #2277629: Add filter example. As the patch contains both port and test.

navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commented
Status: Active » Needs review
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Closed (duplicate)

#2277629: Add filter example is a lot more complete. Closing this issue and rescoping there.