While the filter example currently DOES work as is post-SA-2008-06, it only works because of a bug (\xFF and \xFE are used in a literal manner by php if inside single quotes)

Here is a proper fix that uses unicode private use characters.

Thoughts on this or promoting this fix as the "official" fix for the issue in general?

CommentFileSizeAuthor
filter_utf8_fix.patch1.66 KBbdragon

Comments

betz’s picture

betz commented
Project: Documentation » Drupal core
Version: » 7.x-dev
Component: Documentation in CVS » documentation

Changed the component to reflect the new component categorization. See http://drupal.org/node/301443

Patch failed to apply. More information can be found at http://testing.drupal.org/node/13901. If you need help with creating patches please look at http://drupal.org/patch/create

dries’s picture

dries commented
Status: Needs review » Needs work
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Project: Drupal core » Examples for Developers
Version: 7.x-dev »
Component: documentation » Code
Assigned: bdragon » Unassigned

Moving to the new example modules project.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

The patch failed to apply for me, but with minimal/context changes, I tried it out. ... It looks good, I agree with the reasoning, and the filter works fine in Drupal 6... So I went ahead and committed it to Drupal 6, as well as Drupal 7 (the Drupal 7 code is identical).
http://drupal.org/cvs?commit=275004
http://drupal.org/cvs?commit=275002

Thanks bdragon!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.