I've run across some clutter that I believe is a dead code path left over from when the repeat settings were on their own tab. In _eventrepeat_form_validate() the following code appears:

  //validate exception dates if submitted
  if ($op == t('Add/Delete Exception')) {
    _eventrepeat_validate_form_date('eventrepeat_EXDATE_edit', 'Exception', $node); //NEED TO ADD CHECK FOR 0 HERE
  }

There is no longer a button on the form called 'Add/Delete Exception' after the interface to editing exceptions was improved. The code path within the if() will never get executed.

This exact same call to eventrepeat_validate_form_date() is made in eventrepeat_form_add_exception(). The validation still takes place, just not along the code path hilighted above.

Yes, this time I did sanity check through debugging as opposed to just reading the code. :)

Comments

scott.mclewin’s picture

Priority: Normal » Minor

Reset the priority to minor - missed that on the preview. doh.

seanbfuller’s picture

Status: Active » Fixed

Committed to HEAD.

Anonymous’s picture

Status: Fixed » Closed (fixed)