Closed (fixed)
Project:
EU Cookie Compliance (GDPR Compliance)
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Apr 2016 at 12:27 UTC
Updated:
26 Nov 2017 at 12:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
killua99 commentedI've to move this UI to D8
Comment #3
svenryen commentedComment #4
killua99 commentedan RC1 should have more test cover, also, move it to unit instead simple test?
Comment #5
svenryen commentedCan I recommend we move the discussion about test cover to a different, separate issue, and focus in this issue on the discussion about the interface changes that we need to make in the 8.x version to keep it aligned with 7.x? Then in the other issue we could shortlist the number of tests that needs to be created, who should make them and whether automated tests are really needed for a module that consists of an admin form, some glue code and a javascript.
Comment #6
svenryen commentedThe patch passed tests for 8.3 and as it's purely a reorganization of the admin interface (no new functionality), I suggest we apply the patch to -dev so that it's easier to work on other issues that involve the admin page.
Comment #8
svenryen commentedI'm committing this to dev since there's been no input since August.
I compared the interface and labels to 7.17 and latest beta of 8.x using simplytest.me and confirmed no functions were lost. I cleaned up some inconsistencies involving Title Case and periods at the end of sentences, as well as a color name that was inconsistently written in caps.
I also tested saving the form from a clean install of the module and verified that all settings were stored in the database with the right variable names.
Comment #9
svenryen commented