Follow-up to #2703307: Proposed user interface changes

As patches have been accepted over the years, the interface has grown cluttered, confusing and overwhelming. Plus, may of the settings don't apply to everybody and can be moved to an "Advanced" section to make the interface more appealing and less of a mouthful when first seen.

This issue is aimed for RC1 and to have RC1 we need some extra test coverage.

Comments

killua99 created an issue. See original summary.

killua99’s picture

I've to move this UI to D8

svenryen’s picture

killua99’s picture

Status: Active » Needs work

an RC1 should have more test cover, also, move it to unit instead simple test?

svenryen’s picture

Can I recommend we move the discussion about test cover to a different, separate issue, and focus in this issue on the discussion about the interface changes that we need to make in the 8.x version to keep it aligned with 7.x? Then in the other issue we could shortlist the number of tests that needs to be created, who should make them and whether automated tests are really needed for a module that consists of an admin form, some glue code and a javascript.

svenryen’s picture

The patch passed tests for 8.3 and as it's purely a reorganization of the admin interface (no new functionality), I suggest we apply the patch to -dev so that it's easier to work on other issues that involve the admin page.

  • svenryen committed 01dc712 on 8.x-1.x
    Issue #2707085 by svenryen: Proposed user interface changes D8 RC1
    
svenryen’s picture

I'm committing this to dev since there's been no input since August.

I compared the interface and labels to 7.17 and latest beta of 8.x using simplytest.me and confirmed no functions were lost. I cleaned up some inconsistencies involving Title Case and periods at the end of sentences, as well as a color name that was inconsistently written in caps.

I also tested saving the form from a clean install of the module and verified that all settings were stored in the database with the right variable names.

svenryen’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.