Integration with Services module has miscellaneous minor issues and need to be updated.

CommentFileSizeAuthor
#7 erpal_core_improvements_of_endpoint_urls_2386205_6.patch31.11 KBozin
#5 erpal_core_improvements_of_endpoint_urls_2386205_1.patch24.36 KBozin
#4 erpal_core_improvements_of_erpal_basic_service_module_2386205_1.patch28.13 KBozin
#1 improvements_of_erpal-2386205-1.patch63.68 KBozin

Comments

ozin’s picture

ozin
Primary language Ukrainian
commented
Status: Active » Needs review
StatusFileSize
new improvements_of_erpal-2386205-1.patch63.68 KB

Patch attached, please review.

Anonymous’s picture

Anonymous (not verified) commented

Looks mostly good, but there are some things that need to be fixed before this can be applied:

  • This patch is way too big, really hard to review like this. Please split in smaller patches with a single topic each.
  • erpal_crm/erpal_crm_helper/modules/erpal_crm_service/inc/activity.inc: Patch replaces whole file because of line endings, should only contain actual changes. This part needs to be redone or we would have trouble later on with mergeing this file.
  • Great to get the actual configured endpoints to generate the URLs instead of hardcoding them. This should be applied.
  • Output format: At some places empty arrays are left out instead of being sent as empty arrays. If there is no data for an array we always return an empty array for that field.
  • Output format: For creating contact nodes the node-id field was renamed from 'node' to 'nid'.
  • There is a bug when retrieving contacts, the code returns only the last file instead of all of them.
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work
ozin’s picture

ozin
Primary language Ukrainian
commented
Status: Needs work » Needs review
StatusFileSize
new erpal_core_improvements_of_erpal_basic_service_module_2386205_1.patch28.13 KB

Thanks for your reply! I decide split this patch into 3 smaller patches for 3 modules:

  • ERPAL basic service
  • ERPAL CRM service
  • ERPAL docs service

There is a patch for ERPAL basic service module. I've fixed all remarks from the list above for this module.
Please check this patch and let me if it works for you.

ozin’s picture

ozin
Primary language Ukrainian
commented
StatusFileSize
new erpal_core_improvements_of_endpoint_urls_2386205_1.patch24.36 KB

Added patch which fix endpoints URLs. Please check

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
ozin’s picture

ozin
Primary language Ukrainian
commented
StatusFileSize
new erpal_core_improvements_of_endpoint_urls_2386205_6.patch31.11 KB

Hi @weidauer,

Find re-rolled patch attached.