By using current Feeds dev branch (7.x-2.x-dev from 2014-Jun-12), I found out that your module gives an ajax error which stops import process batch job. The error is due to a change on function text_feeds_set_target available on feeds module (file mappers/text.inc). This change will be on stable branch some day and that's why this need to be fixed. Also, there may be people (including me) who needs to use dev branch for some reasons.

Thanks!

CommentFileSizeAuthor
#6 broken_feeds-2287149-6.patch914 bytesgnucifer
#1 broken_feeds-2287149-2.patch826 bytesrcodina
#1 ajax_error.png177.09 KBrcodina

Comments

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
StatusFileSize
new ajax_error.png177.09 KB
new broken_feeds-2287149-2.patch826 bytes

I enclose a patch I made to avoid the error and get data imported. Could you test it please? I have done some testing and it works ok for me. Thank you!

johnkareoke’s picture

johnkareoke commented

Have the same error, but the patch doesn't seem to work for me. I'm going to try and update it manually and report back

Putting the error in text so it helps people searching for it:

"An error has occurred.
Please continue to the error page

An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /batch?id=1221&op=do StatusText: Service unavailable (with message) ResponseText: Recoverable fatal error: Argument 4 passed to date_feeds_set_target() must be of the type array, string given, called in sites/all/modules/entityreference_feeds/entityreference_feeds.module on line 219 and defined in date_feeds_set_target() (line 38 of sites/all/modules/feeds/mappers/date.inc)."

johnkareoke’s picture

johnkareoke commented

The patch doesn't seem to work for me. Even after applying it manually I still get the same Ajax error on import

gnucifer’s picture

gnucifer commented

I can't reproduce this using 7.x-2.0-alpha8, but I think it has less to do with the version of feeds and more so with the parser used. The values comes directly from the parser(?), and since I'm using the Xpath-parser also single values will be parsed as arrays (I guess). I will look into this a bit deeper, the current patch is absolutely too "special case":ish. There should be a general solution for this, but currently I'm not sure if it is the responsibility of this module to correct these invalid values.

gnucifer’s picture

gnucifer commented

Sorry, I did not realize it was the dev-version you where referring too. I also forgot that array values from the parser will become single values as a consequence as multiple values will be matched up as single values on multiple entities. This is the "hack" this module was build upon. It therefore should make sense to convert all values to arrays before delegating them to the mapper in question, not just for the text mapper. I just hope this will not have any nasty side effects.

gnucifer’s picture

gnucifer commented
StatusFileSize
new broken_feeds-2287149-6.patch914 bytes

Here is a patch that should cover all cases. I hope it's alright if I attribute it to you (rcodina) although I changed it to fix this issue just not for the textfield mapper.

gnucifer’s picture

gnucifer commented
Status: Active » Closed (fixed)

Commited

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented

@gnucifer Thank you so much for this!