Closed (duplicate)
Project:
Entity reference
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
15 Jun 2018 at 14:44 UTC
Updated:
12 Mar 2023 at 22:09 UTC
Jump to comment: Most recent
Comments
Comment #2
joseph.olstadHi MustangGB, since you asked, which remaining issues would you like to see in 1.6? Have they all gone into dev?
rc-1 was tagged, would be nice to get 1.6 released.
Do you recommend tagging a release on the current state of dev?
Comment #3
joseph.olstadI am suggesting some RTBC issues, anything missed?
Comment #4
joseph.olstadall RTBC, except the last one, performance issue, looks good to me.
Comment #5
mustanggb commentedThe main ones I keep coming across are #1702172: Saving allowed even when input is not valid in autocomplete results and #1896210: When filtering autocomplete by a view #default_value always be the entity title instead of the custom view result (e.g. a field on the entity).
Once
#1702172is in #1411304: Autocomplete hide id options for use with unique labels needs looking at.So no, I don't think it's a good time for another tag yet, we should get some of these issues in first.
Comment #6
mustanggb commentedAnother popular issue that would be nice to get some attention.
Comment #7
joseph.olstadok if these are recurring things that come up for you a lot perhaps we could shortlist 1.6 to the issues mentioned in #5
?
Comment #8
bramdriesenWould be very nice to include this one... #2894475: Saving entity ignores the allowed bundles settings when a valid nid is supplied. Using that patch for almost 2 years in production now.
Comment #9
mustanggb commentedBump.
Comment #10
joseph.olstadI've reached out to the maintainer MinorOffence
Comment #11
joseph.olstadComment #12
joseph.olstadI propose an rc2 tag with all the related fixes linked in this issue included.
Comment #13
joseph.olstadComment #14
tr commentedFYI, see https://www.drupal.org/project/entityreference/maintainers.json
@minorOffense doesn't have permission to administer maintainers - only @Damien Tournoud and @amitaibu can do that, and I think that Damien is no longer involved with Drupal.
So, you should pursure co-maintainership by following the process described in https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... which would involve first contacting @amitaibu then waiting two weeks for a response before proceeding with the next step.
Comment #15
joseph.olstadComment #16
spotzero commentedHey, @joseph.olstad, Have you tested the patches in the related issues together?
What we could do is branch a 7.x-2.x branch, and include all of the patches there, while leaving the 1.x branch is a stable. Since *most* Drupal 7 sites are basically in a holding pattern at the moment, I'm hesitant to commit changes because it would affect so many sites that probably are only getting the bare minimum of maintenance.
Comment #17
joseph.olstadya a 7.x-2.x branch would be a good idea, I'm for that, put in a beta release with the related fixes
Comment #18
joseph.olstadrc1 could probably be cut as 1.6 as it's been tagged since 2 years ago
Comment #19
amitaibuHi folks - thanks for the work you put on ER! I've granted @joseph.olstad, but agree with @spotzero that extra care should be given in not breaking anything . Lots of sites rely on the module :)
Comment #20
joseph.olstad@amitaibu , thank you and yes there is risk however we would like to fix the related bugs and support php 7.4, php 8.0
I like the plan of a 7.x-2.x branch with a beta release for 7.x-2.0-beta1
as for 1.6, perhaps it's time to break with 1.x and focus on 2.x going forward. Those still happily on 1.5 or 1.6-rc1 can continue to use it.
Those that want the fixes and improved support will go for the 7.x-2.0-beta1 release.
Any objections?
Comment #21
joseph.olstadComment #22
joseph.olstadComment #23
spotzero commentedHey @joseph.olstad, congrats on the access.
Mat and I are go for this plan.
1.5/1.6rc1 will be the permanent stable (obviously unless there are security issues discovered).
2.x will be the head for bugs and improvements.
I'll leave the 2.x branch for you.
Comment #24
mustanggb commentedLovely news!
Comment #25
joseph.olstadHi sorry I haven't done this yet but tragedy hit my brothers family and I'm too extenuated right now helping family members. Please contact me through d.o if you want to do this for me?
otherwise it'll have to wait a few months until I catch up on a backlog of items.
Comment #26
joseph.olstadhttps://www.drupal.org/project/entityreference/releases/7.x-1.6-rc2
Comment #27
joseph.olstadI went with 7.x-1.6-rc2 due to the importance of the fixes, wanted to get something useful out there.
PHP 8.0, 8.1, 8.2 compatibility now included, and some other bug fixes that have been well ridden.
Comment #28
joseph.olstadI lack permissions to add a 2.x dev build so I've pushed 1.6-rc2 which I do have permissions to do.
Comment #29
joseph.olstadTagged 1.6 because people were reporting issues in 1.5 that have been fixed in 1.6-rc3 , so I decided to tag 1.6
Comment #30
joseph.olstadSince I lack project privileges for branch creation and no one noticed, going with 1.7-rc strategy instead of 2.x
Comment #31
joseph.olstadComment #32
joseph.olstadok so 1.6 seems to be a very successful release, PHP 8.0, 8.1 and PHP 8.2 tests all passing. There's over 5000 upgrades using 1.6.
I made this release because there were numerous bugs in 1.5 and I wanted to offer to everyone an easy (low risk) upgrade for PHP 8.0, PHP 8.1 and PHP 8.2 compatibility. I haven't had any reports of problem with 1.6. All of these commits were well ridden multi year issues except the PHP 8.1/8.2 changes I made which were pretty straight forward.
In follow up from 1.6, Joel Pittet asked for a feature to be committed, I put it in the 7.x-1.x dev branch, it's not in a tagged release.
#2672776: Feeds integration: support mapping option "language"
I've upgraded one of my bilingual documentation sites to Drupal 7.94 and it's using the latest contrib modules and running PHP 8.2, it's super fast and working very well.
With the large install base of Drupal 7 out there I'm sure many will continue to upgrade and take advantage of the performance and scalability benefits of using PHP 8.2 with the latest Drupal 7 core and contrib.
Comment #33
joseph.olstadGoing with this one: #3347507: Plan for 7.x-1.10
Comment #34
mustanggb commented@joseph.olstad Thanks for your hard work.