In #1674792-117: Rendered entity is not language aware strange return statement was introduced in testFieldAdminHandler() entityreference.admin.test was introduced without any explanations which looks like complete testing/debugging leftover.
Also when patch from 117 was committed ALL added entity translation test coverage was lost. This can be check by comparing commit with a patch in #1674792-117: Rendered entity is not language aware. New files was not added to index.

CommentFileSizeAuthor
#4 entityreference-2841498-interdiff-2-4.txt439 bytesrosk0
#4 entityreference-2841498-4.patch33.72 KBrosk0
#2 entityreference-2841498-2.patch33.29 KBrosk0

Comments

RoSk0 created an issue. See original summary.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Assigned: rosk0 » Unassigned
Status: Active » Needs review
Parent issue: » #1674792: Rendered entity is not language aware
StatusFileSize
new entityreference-2841498-2.patch33.29 KB

Restored entity translation test coverage.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Issue summary: View changes

For some reason new tests was not picked up :(

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
StatusFileSize
new entityreference-2841498-4.patch33.72 KB
new entityreference-2841498-interdiff-2-4.txt439 bytes

Probably missed test dependencies...

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented

What the ...?!? Locally it's picking up new tests, failing but picking up:

$ php scripts/run-tests.sh --color  --directory sites/all/modules/vcs/entityreference

Drupal test run
---------------

Tests to be run:
 - Entity Reference UI (EntityReferenceAdminTestCase)
 - Entity Translation integration (EntityReferenceEntityTranslationTestCase)
 - Entity Reference Handlers (EntityReferenceHandlersTestCase)
 - Entity Reference Taxonomy (EntityReferenceTaxonomyTestCase)

Test run started:
 Friday, January 6, 2017 - 15:31

Test summary
------------

Entity Reference UI 44 passes, 0 fails, 0 exceptions, and 12 debug messages
Entity Translation integration 17 passes, 2 fails, 0 exceptions, and 4 debug messages
Entity Reference Handlers 76 passes, 0 fails, and 0 exceptions
Entity Reference Taxonomy 7 passes, 0 fails, and 0 exceptions

Test run duration: 1 min 21 sec

Need some help to figure out why is it not picking up new tests.