Patch adds optional $instance. Like this, for example, in buildEntityFieldQuery() we can build the query based on the instance.

CommentFileSizeAuthor
er-pass-instance.patch3.84 KBamitaibu

Comments

damien tournoud’s picture

damien tournoud commented

We do have the instance everywhere; except in some weird backward compatibility cases for entityreference_options_list(). The question is: what do we do when the instance is not passed?

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

> what do we do when the instance is not passed?

We assign $instance = NULL by default, as we can't do a smart on such cases.

Status: Needs review » Needs work

The last submitted patch, er-pass-instance.patch, failed testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Closed (duplicate)

Fixed in #1343854: Separate "Selection" and "behavior" to different plugins