Invoke field_[op] in the handler [#1343918]

Patch allows an implementing handler to act upon field change, e.g. act on hook_field_presave()

This patch is still not finished, as there are other operations that need to be invoked (all ops from _invoke_field), but I'm setting to needs review to see if this approach is acceptable.

My use case, is that OG can provide own handler with own field_validate| insert| update logic.

Comment	File	Size	Author
#5	1343918-er-invoke-field-handler-5.patch	3.49 KB	amitaibu
#5
#4	1343918-er-invoke-field-handler-4.patch	3.49 KB	amitaibu
#4
#1	1343918-er-invoke-field-handler-1.patch	2.3 KB	amitaibu
#1
	er-invoke-field-handler.patch	1.4 KB	amitaibu

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 20 November 2011 at 19:07

File	Size
1343918-er-invoke-field-handler-1.patch	2.3 KB

Added insert/ update/ delete.

Comment #2

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 29 November 2011 at 11:37

@Damz, I've implemented this in OG7's new dev branch. Can you please let me know if it's an acceptable improvement?

Comment #3

Damien Tournoud CreditAttribution: Damien Tournoud commented 29 November 2011 at 15:26

So we have rewrote the Field API as a CTools plugin? :)

Yes, this is acceptable. I'm not a fan of the implementation, could we convert that into a single call_user_func_array()? The signature of the entityreference_field_invoke_handler() scares me.

Comment #4

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 1 December 2011 at 19:27

File	Size
1343918-er-invoke-field-handler-4.patch	3.49 KB

I've also added hook_field_load() -- My use case is here (although I'm not sure if it is indeed what OG will do in the end)

The patch doesn't work, because, well a bit embarrassing... but I didn't find how to pass the values by reference using call_user_func_array() :/ -- what am I missing there?