Problem/Motivation

Saving an entityqueue, e.g. after reordering or adding / removing entries, users which only have an update permission on that specific entityqueue are getting access denied (403) message because they are not allowed to access the path they are redirected to

Steps to reproduce

  1. Edit an entityqueue, e.g. /admin/structure/entityqueue/highlights_hero_slightshow_front/highlights_hero_slightshow_front
  2. Click "Save"
  3. See "Access denied" because after save you're redirected to /admin/structure/entityqueue

Proposed resolution

Instead of redirecting to the /admin/structure/entityqueue page with no access, you'd expect to be kept on the same page, e.g. /admin/structure/entityqueue/highlights_hero_slightshow_front/highlights_hero_slightshow_front

Remaining tasks

Fix
Test
Release

User interface changes

None

API changes

None

Data model changes

None

Issue fork entityqueue-3581435

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

This is quite confusing for users because they may think their changes have not been saved seeing that Access denied error!

jatin.buzz’s picture

jatin.buzz commented

Working on it.

jatin.buzz opened merge request !41

jatin.buzz’s picture

jatin.buzz commented
Status: Active » Needs review

Please review the MR.
Made changes to the form submit which fixes the bug where 403 was shown after clicking the save button.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.10 » 8.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Thank you @jatin.buzz! This works perfectly well and as expected!
Also the redirect parameter still works fine.
Thank you also for the test!

  • amateescu committed 59117ec7 on 8.x-1.x authored by jatin.buzz 
    fix: #3581435 After saving an entityqueue 403 with update permissions...
amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Looks good to me. Merged into 8.x-1.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.