Problem/Motivation
After creating a new subqueue it is possible to then change the display 'Name' (whilst retaining the machine name). See screenshot 
This is useful when using a programatic naming convention whilst allowing customer facing queues to use 'Friendly names'.
However this falls down when the 'Edit subqueue' page uses the machine name in the title (Not the 'Friendly Name'). See screenshot
.
Proposed resolution
Allow 'Name' to be used by the 'Edit subqueue' page.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2987710_labels_update_5.patch | 911 bytes | sagesolutions |
| #4 | 2987710-4.patch | 553 bytes | amateescu |
| #2 | subqueue_name-2987710-2.patch | 745 bytes | danielveza |
| Edit subqueue.png | 28.28 KB | racinggrinner | |
| Edit Entity Queue.png | 55.87 KB | racinggrinner |
Comments
Comment #2
danielvezaAttaching a patch that fixes this.
I think the desired behaviour should be that the display is "Edit subqueue {Parent queue title}", so thats what my patch does.
Open for other suggestions!
Comment #3
dieuweApplies and works nicely, good UI improvement.
Comment #4
amateescu commentedThis patch only works when you are dealing with simple queues, which means that every queue will only have a single subqueue. But when you create a queue with multiple subqueues, each subqueue will have a different name, so we can not display the queue name when editing a subqueue because that will be terribly confusing.
That's not really accurate, we display the subqueue label, not the subqueue machine name.
I think the proper way to fix this is to handle the possible inconsistent labels in
\Drupal\entityqueue\Plugin\EntityQueueHandler\Simple::onQueuePostSave().Can you try this patch and let me know if it works for you?
Comment #5
sagesolutions commentedI agree, \Drupal\entityqueue\Plugin\EntityQueueHandler\Simple::onQueuePostSave() is the best way to update this. see attached patch.
Comment #6
amateescu commentedI like the patch in #5, it's more clear if we go with the non-negated condition first.
Committed to 8.x-1.x. Thanks!