Queue is always required when using "Limit to a specific entity queue" even when specifying that this relation is not required from views, this results in that you cannot add multiple sorts and having a "not in the queue" relationship.

CommentFileSizeAuthor
#8 interdiff.txt1.89 KBamateescu
#8 2821631-8.patch1.69 KBamateescu
#5 entityqueue-moved_queue_condition_to_join-2821631-5.patch1.64 KBjosebc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

josebc created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Active

Interesting :) Do you think you can investigate a bit and post a patch for this? It would be nice to have it fixed in alpha5.

josebc’s picture

josebc CreditAttribution: josebc at Vardot commented
Status: Active » Needs work

on it :)

josebc’s picture

josebc CreditAttribution: josebc at Vardot commented
Status: Needs work » Active
josebc’s picture

josebc CreditAttribution: josebc at Vardot commented
Status: Active » Needs review
FileSize
entityqueue-moved_queue_condition_to_join-2821631-5.patch1.64 KB

moved condition to join instead of where
patch attached

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

Rewarded work Jose!

Testing :)

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
Assigned: josebc » Unassigned
Status: Needs review » Reviewed & tested by the community
amateescu’s picture

amateescu CreditAttribution: amateescu as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
2821631-8.patch1.69 KB
interdiff.txt1.89 KB

Nice work! I tested the patch from #5 and it fixes only the first part of the problem: the queue is no longer required unless the relationship itself is required.

However, the "not in the queue" filter still doesn't behave as expected.

I was able to fix it easily by removing the extra WHERE from \Drupal\entityqueue\Plugin\views\filter\EntityQueueInQueue.

Can you please test this patch and let me know if everything works correctly now?

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

Testing ......

amateescu’s picture

amateescu CreditAttribution: amateescu as a volunteer commented

@RajabNatshah, still testing? :)

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

Tested;
I'm using your last patch now
https://github.com/Vardot/varbase/blob/8.x-4.x/composer.json

https://travis-ci.org/Vardot/varbase/jobs/182250366

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

Thank you for your work on this.

I'm having a week for Automated Testing to add more testing features. at

https://github.com/Vardot/varbase/blob/8.x-4.x/tests/features/varbase/st...

https://github.com/Vardot/varbase/blob/8.x-4.x/tests/features/varbase/st...
https://github.com/Vardot/varbase/blob/8.x-4.x/tests/features/varbase/st...

https://github.com/Vardot/varbase/blob/8.x-4.x/tests/features/varbase/st...

#Automation: Have more automated functional testing gherkin features

I will do this issue after this post.

  • amateescu committed b3fd10b on 8.x-1.x 
    Issue #2821631 by amateescu, josebc: Queue is always required when using...
amateescu’s picture

amateescu CreditAttribution: amateescu as a volunteer commented
Status: Needs review » Fixed

Committed the patch from #8 to 8.x-1.x. Thanks everyone :)

josebc’s picture

josebc CreditAttribution: josebc at Vardot commented
Status: Fixed » Needs work

Latest patch will not limit the results to queue, moving parent::query(); above makes it ignore the extra

amateescu’s picture

amateescu CreditAttribution: amateescu as a volunteer commented
Status: Needs work » Fixed

That's being fixed in #2837841: Subqueue views relation: Doubled/redundant entries.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.