Nodequeue provides buttons for:

  • Shuffling/randomizing the order
  • Reversing the order
  • Clearing the queue

It would be nice to have the same options.

CommentFileSizeAuthor
#5 interdiff-2144977-3-5.txt1.81 KBjojonaloha
#5 entityqueue-shuffle-reverse-clear-btns-2144977-5.patch5.1 KBjojonaloha
#3 interdiff-2144977-1-3.txt2.68 KBjojonaloha
#3 entityqueue-shuffle-reverse-clear-btns-2144977-3.patch5.12 KBjojonaloha
#1 entityqueue-shuffle-reverse-clear-btns-2144977-1.patch3.6 KBjojonaloha

Comments

jojonaloha’s picture

jojonaloha commented
Status: Active » Needs review
StatusFileSize
new entityqueue-shuffle-reverse-clear-btns-2144977-1.patch3.6 KB

Attached patch adds the Shuffle, Reverse and Clear actions. I tried making them #type=button instead of #type=submit, so that you stayed on the edit form like Nodequeue does, but it doesn't seem that the form values are updated appropriately (at least the way I'm doing it in this patch) when I do that.

amateescu’s picture

amateescu commented
Status: Needs review » Needs work

We should try to make these operations work via AJAX. Right now, the action happens and you're redirected to the queue listing, which is.. not the best user experience :)

jojonaloha’s picture

jojonaloha commented
Version: » 7.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new entityqueue-shuffle-reverse-clear-btns-2144977-3.patch5.12 KB
new interdiff-2144977-1-3.txt2.68 KB

Updated patch makes the buttons use ajax. Currently clicking one of these buttons doesn't add a "Changes will not be saved until the form is submitted" message because that will just make this issue worse #2154115: Duplicate "Changes will not be saved until the form is submitted." warnings

amateescu’s picture

amateescu commented 
  1. +++ b/entityqueue.module
@@ -1010,3 +1010,13 @@ function entityqueue_field_widget_ajax_callback($form, $form_state) {
+  $subqueue = $form_state['entityqueue_subqueue'];

    This is not used in the function. 

  2. +++ b/plugins/ctools/export_ui/entityqueue_export_ui.class.php
@@ -286,6 +286,12 @@ function entityqueue_subqueue_edit_form($form, &$form_state, EntityQueue $queue,
+  // We don't use drupal_html_id() here because we don't want the wrapper id
+  // to change each time the ajax form is submitted.
+  $field_name = _entityqueue_get_target_field_name($queue->target_type);
+  $wrapper_id = drupal_clean_css_identifier($field_name . '-wrapper');
+  $form[$field_name]['#id'] = $wrapper_id;

    This means that the field wrapper will have the same id if we have multiple instances of this form on the same page. It would be easier to add a div wrapper with #prefix and #suffix, and use drupal_html_id() for its id.

jojonaloha’s picture

jojonaloha commented
StatusFileSize
new entityqueue-shuffle-reverse-clear-btns-2144977-5.patch5.1 KB
new interdiff-2144977-3-5.txt1.81 KB

Attached patch uses drupal_html_id() for the wrapper id. In order for that to work the entire form needs to be replaced, otherwise the second or third click of one of the ajax buttons will not work because they are referencing the old wrapper id.

This means that the field wrapper will have the same id if we have multiple instances of this form on the same page.

This also means that the code in entityqueue_field_widget_form() would need to be updated. Also, I'm wondering when we'd have multiple instances of the form on the same page? I was thinking that IEF might be an example, but doesn't that still only have one instance of the form on the page at a time?

amateescu’s picture

amateescu commented

There was a bug/feature request in nodequeue (back in the day..) about a custom module that provided queue forms in blocks and that's how they ended up with multiple queue forms on one page :)

I don't think returning the entire form bothers us too much, so the patch looks good to me.

jojonaloha’s picture

jojonaloha commented

Ok, I think I'm going to commit this and create a follow-up issue for the widget form then.

amateescu’s picture

amateescu commented

Go right ahead :)

jojonaloha’s picture

jojonaloha commented
Status: Needs review » Fixed

Committed 0518829

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.