Problem/Motivation

According to Drupal-check, this module is using some deprecated code that will be removed from Drupal 9. Before this module can be used with Drupal 9, it's needs 2 things:
1) Those deprecations fixed
2) The `core_version_requirement` line in the info.yml file, per
https://www.drupal.org/node/3070687

Comments

joshua.boltz created an issue. See original summary.

joshua.boltz’s picture

StatusFileSize
new393 bytes

Attached is a patch that adds the `core_version_requirement` line to the info.yml file, per:
https://www.drupal.org/node/3070687

Unfortunately, it's not applying for me, and not really sure why.
This is the .rej file contents:

***************
*** 1,4 ****
  name: Entity Reference validators
  type: module
  description: 'Provides additional validators for entity reference fields.'
- core: 8.x
--- 1,4 ----
  name: Entity Reference validators
  type: module
  description: 'Provides additional validators for entity reference fields.'
+ core_version_requirement: ^8 || ^9

Perhaps someone else can figure out how to make this patch so it can apply.

joshua.boltz’s picture

StatusFileSize
new393 bytes

Adds patch that applied cleanly to add the missing `core_version_requirement` line.
Note, I had to add the line directly below the `name` property, which is not the ideal location, but it works.

joshua.boltz’s picture

joshua.boltz’s picture

Status: Active » Needs review
pcambra’s picture

Status: Needs review » Reviewed & tested by the community

pcambra’s picture

Status: Reviewed & tested by the community » Fixed
pcambra’s picture

Thanks!!!

joshua.boltz’s picture

I just noticed after putting the latest dev into my project that it was still giving this in composer.lock

            "require": {
                "drupal/core": "~8"
            },

Which is an issue and will be blocking a D9 upgrade due to that requirement. This should be removed from the module's composer.json file, so that when composer pulls in the project, it can assign the proper values in the composer.lock based on the `core_version_requirement` values present in the info.yml file.

pcambra’s picture

Ah, good point, feel free to open another issue with a patch for this :), otherwise I'll commit the fix in a few days

joshua.boltz’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.