Closed (fixed)
Project:
Entity Reference Validators
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Oct 2020 at 03:37 UTC
Updated:
17 Nov 2020 at 20:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
joshua.boltz commentedAttached is a patch that adds the `core_version_requirement` line to the info.yml file, per:
https://www.drupal.org/node/3070687
Unfortunately, it's not applying for me, and not really sure why.
This is the .rej file contents:
Perhaps someone else can figure out how to make this patch so it can apply.
Comment #3
joshua.boltz commentedAdds patch that applied cleanly to add the missing `core_version_requirement` line.
Note, I had to add the line directly below the `name` property, which is not the ideal location, but it works.
Comment #4
joshua.boltz commentedComment #5
joshua.boltz commentedComment #6
pcambraComment #8
pcambraComment #9
pcambraThanks!!!
Comment #10
joshua.boltz commentedI just noticed after putting the latest dev into my project that it was still giving this in composer.lock
Which is an issue and will be blocking a D9 upgrade due to that requirement. This should be removed from the module's composer.json file, so that when composer pulls in the project, it can assign the proper values in the composer.lock based on the `core_version_requirement` values present in the info.yml file.
Comment #11
pcambraAh, good point, feel free to open another issue with a patch for this :), otherwise I'll commit the fix in a few days
Comment #12
joshua.boltz commentedYup, I already did. See https://www.drupal.org/project/entity_reference_validators/issues/3180478