We want to have tests that ensure that entities are previewed correctly when using the entity reference integration.

CommentFileSizeAuthor
#12 3133699--additional-functional-testing-preview--12.patch9.67 KBe0ipso
#6 3133699--initial-functional-testing--6.patch13.48 KBe0ipso
#4 3133699--initial-functional-testing--4.patch13.59 KBe0ipso
#3 3133699-3.patch13.43 KBmarcoscano

Comments

e0ipso created an issue. See original summary.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Title: Add function test coverage for preview on entity reference integration » Add functional test coverage for preview on entity reference integration
marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Active » Needs review
StatusFileSize
new 3133699-3.patch13.43 KB

Here's a first attempt to get this rolling. Although the patch is big because all of the scaffolding, etc, the test itself is quite short. I'm unsure about the different scenarios we need to cover in this case, happy to hear your feedback on that.

I'm willing to continue writing more tests, once we get aligned in the direction to go.

Thanks!

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 3133699--initial-functional-testing--4.patch13.59 KB

Reroll after a separate issue landed.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Needs work

Bad reroll. The enableToolbarIntegration is not indented correcty. Fix to come.

Tests look GREAT. I am inclined to merge as is, then work on more coverage later.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Needs review
StatusFileSize
new 3133699--initial-functional-testing--6.patch13.48 KB

Fixed the indentation in the schema. Omitting interdiff as it is trivial.

  • e0ipso committed 886af55 on 8.x-0.x 
    Issue #3133699 by e0ipso, marcoscano: Add functional test coverage for...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

Fixed! 🎉

  • e0ipso committed f61822e on 8.x-0.x authored by marcoscano 
    Issue #3133699 by e0ipso, marcoscano: Add functional test coverage for...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Drupal.org had a hiccup and didn't change the git author when changing it in the radio button. I added an extra commit to grant authorship.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Fixed » Needs work

Re-opening to test the following edge cases:

  1. Assert that disabling the indicator via settings removes the indicator without stale caches.
  2. Assert that no access check is skipped while previewing for security reasons.
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Needs review
StatusFileSize
new 3133699--additional-functional-testing-preview--12.patch9.67 KB

Let's see if this comes back green.

  • e0ipso committed bde5421 on 8.x-0.x authored by marcoscano 
    Issue #3133699 by e0ipso, marcoscano: Add functional test coverage for...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.