CommentFileSizeAuthor
#8 2862861-8.patch55.49 KBbenjy
#7 interdif.txt7.86 KBbenjy
#7 2862861-7.patch55.49 KBbenjy
#6 2862861-6.patch48.6 KBbenjy
#5 interdif.txt553 bytesbenjy
#5 2862861-5.patch48.24 KBbenjy
#3 interdif.txt5.54 KBbenjy
#3 2862861-3.patch47.7 KBbenjy
#2 2862861-2.patch42.73 KBbenjy

Comments

benjy created an issue. See original summary.

benjy’s picture

benjy commented
Status: Active » Needs review
StatusFileSize
new 2862861-2.patch42.73 KB

Nearly got them all, there was a lot more than I was expecting!

benjy’s picture

benjy commented
StatusFileSize
new 2862861-3.patch47.7 KB
new interdif.txt5.54 KB

Fixed all but this one which is pretty annoying, would need an upgrade path.

FILE: ...Sites/d8/app/modules/entity_print/src/Annotation/PrintEngine.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 33 | ERROR | Class property $export_type should use lowerCamel
    |       | naming without underscores
----------------------------------------------------------------------

Status: Needs review » Needs work

The last submitted patch, 3: 2862861-3.patch, failed testing.

benjy’s picture

benjy commented
Status: Needs work » Needs review
StatusFileSize
new 2862861-5.patch48.24 KB
new interdif.txt553 bytes
benjy’s picture

benjy commented
StatusFileSize
new 2862861-6.patch48.6 KB

Final one

benjy’s picture

benjy commented
StatusFileSize
new 2862861-7.patch55.49 KB
new interdif.txt7.86 KB

More fixes.

benjy’s picture

benjy commented
StatusFileSize
new 2862861-8.patch55.49 KB

Removed some whitespace.

  • benjy committed e44245a on 8.x-2.x 
    Issue #2862861 by benjy: Clean-up PHPCS warnings
benjy’s picture

benjy commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.