Lets improve the 7.x-1.x-dev branch using the Drupal Coding Standards (https://www.drupal.org/coding-standards).

CommentFileSizeAuthor
#19 2720899-19.patch7.1 KBjordanpagewhite
#14 2720899-14.patch6.65 KBjordanpagewhite
#9 2720899-9.patch7.45 KBjordanpagewhite
#7 2720899-7.patch6.65 KBjordanpagewhite
#5 2720899-5.patch6.65 KBjordanpagewhite
#2 2720899-2.patch6.65 KBjordanpagewhite

Comments

jordanpagewhite created an issue. See original summary.

jordanpagewhite’s picture

jordanpagewhite commented
Status: Active » Needs review
StatusFileSize
new 2720899-2.patch6.65 KB

Please review these edits. Again, as I said in the description, I am just trying to use the Drupal Coding Standards on this 7.x-1.x-dev branch. Please let me know if you see anything that you are concerned with. I would be happy to make edits or improvements. Benjy, I assume you wrote tests/entity_print.test, so if you want to write a class doc comment. If there is nothing distinct that should go into that test class doc comment, maybe we should just use an {@inheritdoc}. Let me know.

Status: Needs review » Needs work

The last submitted patch, 2: 2720899-2.patch, failed testing.

benjy’s picture

benjy commented

Thanks, happy to commit this once the patch applies cleanly.

+++ b/entity_print.api.php
@@ -2,9 +2,9 @@
+ * This code provide in this file does not work.

The code provided*

jordanpagewhite’s picture

jordanpagewhite commented
Status: Needs work » Needs review
StatusFileSize
new 2720899-5.patch6.65 KB

Thanks! I fixed that line.

Status: Needs review » Needs work

The last submitted patch, 5: 2720899-5.patch, failed testing.

jordanpagewhite’s picture

jordanpagewhite commented
Status: Needs work » Needs review
StatusFileSize
new 2720899-7.patch6.65 KB

Hmm. Trying to figure out why the patch isn't applying cleanly.

Status: Needs review » Needs work

The last submitted patch, 7: 2720899-7.patch, failed testing.

jordanpagewhite’s picture

jordanpagewhite commented
StatusFileSize
new 2720899-9.patch7.45 KB

I forgot to pull the latest commit (http://cgit.drupalcode.org/entity_print/commit/?id=ca3ace9).

jordanpagewhite’s picture

jordanpagewhite commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 2720899-9.patch, failed testing.

jordanpagewhite’s picture

jordanpagewhite commented

All the tests are passing locally for me. I can't figure out why they're failing here. If anyone has a suggestion, let me know. Thanks.

benjy’s picture

benjy commented

The link you posted was to a commit on the 8.x-1.x branch but this patch looks to be agains the 7.x-1.x branch? Are you creating your patch against the correct branch?

jordanpagewhite’s picture

jordanpagewhite commented
StatusFileSize
new 2720899-14.patch6.65 KB

Haha. You are right. What a silly mistake. Well, I removed those two lines of tags.

jordanpagewhite’s picture

jordanpagewhite commented
Status: Needs work » Needs review
jordanpagewhite’s picture

jordanpagewhite commented

Wait, isn't #2718427 (https://www.drupal.org/node/2718427) on the 7.x-1.x-dev branch?

Status: Needs review » Needs work

The last submitted patch, 14: 2720899-14.patch, failed testing.

benjy’s picture

benjy commented

Yeah sorry, that is the 7.x branch, misread it from cgit. Still not sure why your patch isn't applying? You don't have a patched version or anything do you?

jordanpagewhite’s picture

jordanpagewhite commented
Status: Needs work » Needs review
StatusFileSize
new 2720899-19.patch7.1 KB

Okay, I deleted my repo and pulled down the 7.x branch again to start from scratch. Hopefully this does this trick.

benjy’s picture

benjy commented
Assigned: jordanpagewhite » Unassigned
Status: Needs review » Fixed

Thanks, committed.

+++ b/entity_print.api.php
@@ -38,7 +39,7 @@ function hook_entity_print_css($entity_type, $entity) {
- * @param $entity
+ * @param array $entity

Changed this to object on commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.