Closed (fixed)
Project:
Entity log
Version:
8.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Nov 2022 at 19:14 UTC
Updated:
2 Dec 2022 at 16:49 UTC
Jump to comment: Most recent
Problem/Motivation
At the moment nothing uses the defined entity_log.entitylogconfig configuration file.
Proposed resolution
Delete this file, and write a hook_update() to remove this useless configuration from sites.
Remaining tasks
Deleting the file is trivial.
The next step is to create an entity_log.install file that defines the hook_update_1001() function to delete this config from the database of sites running this module.
Comments
Comment #2
avpadernoThe machine name of the configuration object used by the module is entity_log.configuration. That means that, eventually, that file should be entity_log.configuration.yaml.
Looking at the code, I still have to understand if there are default values for that configuration object. If there are, then the entity_log.configuration.yaml file can be used (and it should be populated with default values); otherwise, it's not necessary.
Comment #3
jcnventura@apaderno, no there is nothing the other real configuration file has as default. It could however have a defined schema, which I have filed as a separate issue.
This issue is fine as is, and that file should just be deleted, and removed from existing sites.
Comment #4
avpaderno@jcnventura I apologize: I didn't mean the report is wrong. I was confirming the issue and that either the file is used for the default values or it's removed.
Comment #5
jcnventuraNo need to apologize. Thanks for paying attention to this issue queue.
Comment #7
jcnventura