Active
Project:
Entity Embed
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Nov 2026 at 18:12 UTC
Updated:
19 Nov 2026 at 18:12 UTC
Jump to comment: Most recent
Generated with the help of an LLM.
On Drupal 12, Symfony's DebugClassLoader reports that core methods we override "might add" a native return type in the next major. The phpunit job on the next major lists these classes:
EntityEmbedDisplayBase, FieldFormatterEntityEmbedDisplayBase, EntityEmbedDisplayManager::createInstance()EntityEmbedDialog (create(), buildForm(), getFormId())EntityEmbedFilter (create(), process(): FilterProcessResult, tips(): ?string)Plugin\EmbedType\Entity (including getDefaultIconUrl(): string)DrupalEntity, DrupalEntityDeriver, FieldFormatterDeriver, ViewModeDeriverEntityReferenceFieldFormatter (trustedCallbacks()), FileFieldFormatter, ImageFieldFormatter, MediaImageDecorator, ViewModeFieldFormatterWhen core adds these return types, our overrides without them will cause fatal errors.
Adding a return type to a method that other modules may override breaks those subclasses. So:
EntityEmbedDisplayBase, FieldFormatterEntityEmbedDisplayBase) and EntityEmbedDisplayManager for 2.0.x, which #3639495: [meta] What to remove in 2.0.x tracks, unless core adds the types before then.
Comments