Problem/Motivation

Once you edit the embedded entity then console starts throwing

CKEditorError: Cannot read properties of null (reading 'set')

Steps to reproduce

Refer branch: https://git.drupalcode.org/issue/entity_embed-3430164/-/tree/3430164-d11... (For D11 compatible) ~~ This branch includes the EMBED module 1.8 tag release

  1. Create new content and click on E button using Full HTML filter format or any other in which Entity Embed button is included in the available button toolbar for ckeditor5.
  2. Modal will pop-up then select existing content and proceed choosing with label or entity id on the next page.
  3. Selected data will appear in the editor, now click on edit of the embedded entity.
  4. Choose another value from dropdown i.e full content to display, you will notice the console error.
  5. Previous selected entity data will remains same.

Attaching the screenshot for your reference.
Failing on edit.

CommentFileSizeAuthor
Screenshot 2024-10-22 at 11.08.41 PM.png443.48 KBankitv18

Comments

ankitv18 created an issue. See original summary.

gslente’s picture

gslente commented

Hello @ankitv18.

Tested the issue on a separate local environment using the steps you mentioned.
Was unable to reproduce the issue on my local environment.
Are there any extra steps that need to be performed to replicate the issue?

ankitv18’s picture

ankitv18 commented
Issue summary: View changes
ankitv18’s picture

ankitv18 commented

Hi @gslente,
I've updated the steps to reproduce. Plan is to make entity_embed D11 compatible.

loze’s picture

loze commented

This is happening for me too, clicking on the edit (pencil icon) opens the dialog and throws the js error. Any edits made in that dialog are not saved.