Tests are currently failing on Drupal 9; see https://www.drupal.org/pift-ci-job/1652032. We need to fix this, or we can't really make other changes to this module.

CommentFileSizeAuthor
#6 interdiff-3128614-4-6.txt317 bytesphenaproxima
#6 3128614-6.patch20.72 KBphenaproxima
#4 3128614-4.patch20.51 KBphenaproxima
#2 3128614-2.patch992 bytesphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 3128614-2.patch992 bytes

Let's start by adding $defaultTheme to the base classes for most tests, and see how many failures that fixes.

Status: Needs review » Needs work

The last submitted patch, 2: 3128614-2.patch, failed testing. View results

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3128614-4.patch20.51 KB

This should greatly reduce, though not outright eliminate, the failures. No interdiff because there were so many changes this time that it would probably be bigger than the patch itself.

Note that this will NOT pass on 8.8.x until #3126797: [D8 only] Add forwards-compatibility shim for assertString(Not)ContainsString()replacements in phpunit 6&7 lands in core. Based on the discussion in that issue, it looks very likely to be committed soon. But, for now, I'm not going to test this patch against 8.8.x.

Status: Needs review » Needs work

The last submitted patch, 4: 3128614-4.patch, failed testing. View results

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3128614-6.patch20.72 KB
new interdiff-3128614-4-6.txt317 bytes

This should fix the final failure.

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Needs review » Reviewed & tested by the community

OK, this looks good. Marking RTBC. I think we can live without the tests passing on 8.8 for the time being.

  • phenaproxima committed f533c5e on 8.x-1.x 
    Issue #3128614 by phenaproxima: Get tests passing on Drupal 9
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Thanks, @oknate! Committed and pushed to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.