The entity_embed.twig.entity_embed_twig_extension still uses the deprecated entity.manager service, and since it does not exist in Drupal 9, it breaks when testing with Drupal 9.

CommentFileSizeAuthor
#2 3111393-2.patch577 byteskatherined

Comments

katherined created an issue. See original summary.

katherined’s picture

katherined
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3111393-2.patch577 bytes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Remove deprecated service » EntityEmbedTwigExtension uses deprecated entity.manager in its service definition

Re-titling for clarity.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. The D9 test failures are all pre-existing; see https://www.drupal.org/pift-ci-job/1567184.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed beadf30 to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.